Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clone-core: update clone core script to remove old files #1873

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

gotmax23
Copy link
Collaborator

See the linked issue. The lingering setup.py and setup.cfg files from
older versions of ansible-core were breaking a local user's doc build.
The clone-core script should automatically remove these.

Relates: ansible/ansible#83937

Copy link
Contributor

@oraNod oraNod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff. Thanks for being so quick with the fix @gotmax23 🚀

@oraNod oraNod added no_backport This PR should not be backported. devel only. tooling This PR affects tooling (CI, pr_labeler, noxfile, linters, etc.) but not the docs builds themselves. labels Sep 12, 2024
Copy link
Contributor

@samccann samccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this (and the added comments! really helps)

See the linked issue. The lingering setup.py and setup.cfg files from
older versions of ansible-core were breaking a local user's doc build.
The clone-core script should automatically remove these.

Relates: ansible/ansible#83937
@gotmax23
Copy link
Collaborator Author

Rebased on top of devel

@gotmax23 gotmax23 added the merge_commit Use "Create a merge commit" when applying this PR label Sep 12, 2024
@gotmax23 gotmax23 merged commit b09a200 into ansible:devel Sep 12, 2024
9 checks passed
@gotmax23
Copy link
Collaborator Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge_commit Use "Create a merge commit" when applying this PR no_backport This PR should not be backported. devel only. tooling This PR affects tooling (CI, pr_labeler, noxfile, linters, etc.) but not the docs builds themselves.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants