Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: refresh dev dependencies #315

Merged
merged 1 commit into from
Aug 21, 2023
Merged

ci: refresh dev dependencies #315

merged 1 commit into from
Aug 21, 2023

Conversation

github-actions[bot]
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the dependency_update PR to update pinned dependencies label Aug 21, 2023
@gotmax23 gotmax23 self-assigned this Aug 21, 2023
@gotmax23
Copy link
Collaborator

I'll merge this after CI passes.

@gotmax23 gotmax23 closed this Aug 21, 2023
@gotmax23 gotmax23 reopened this Aug 21, 2023
@github-actions github-actions bot added the needs_triage Needs a first human triage before being processed. label Aug 21, 2023
@gotmax23 gotmax23 merged commit 4ec04d6 into devel Aug 21, 2023
6 checks passed
@gotmax23 gotmax23 deleted the pip-compile/devel/dev branch August 21, 2023 19:03
@gotmax23 gotmax23 removed the needs_triage Needs a first human triage before being processed. label Aug 21, 2023
@samccann
Copy link
Contributor

@gotmax23 - this has no reviews. We should only merge dependency changes with at least two approvals.

What tests were done to verify the updated dependencies were okay (other than passing CI)?

@gotmax23
Copy link
Collaborator

This PR only affects the dependencies used by the Python linters. They have zero effect on the docs build. See #258 (comment). I split the linters' dependency update PRs into separate PRs so they could be merged as soon as CI passes. Some repos even have these types of PRs automerge. My reason for pinning the linters in the first place is prevent linter updates from breaking our CI when they e.g. add new rules. As long as the linters still pass, there shouldn't be anything else to check. If you want double reviews for these PRs, I'm happy to oblige, but that feels overkill to me.

@felixfontein
Copy link
Collaborator

👍 for keeping the linter requirements updated without much procedure.

@samccann
Copy link
Contributor

This was still merged with zero approvals. Something we should avoid in the future.

gotmax23 pushed a commit to gotmax23/ansible-documentation that referenced this pull request Aug 27, 2023
(cherry picked from commit 4ec04d6)

Co-authored-by: Github Actions <41898282+github-actions[bot]@users.noreply.github.com>
@gotmax23
Copy link
Collaborator

It wasn't zero approvals. I reviewed the PR.

@samccann
Copy link
Contributor

Sorry coming back late here and apologies to @gotmax23 - i've been confusing a few things about these dependencies update PRs... I think I've got it figured out now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency_update PR to update pinned dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants