Add details of interactions between notifications and loops #597
Conversation
This clarifies behaviour raised in ansible/ansible#81950 and ansible/ansible#77550 as expected and documented.
github-actions
bot
added
the
needs_triage
gotmax23
added
the
new_contributor
gotmax23
added
backport-2.15
|
@lod, are you still interested in proceeding with this PR? |
Co-authored-by: Maxwell G <[email protected]>
samccann
removed
needs_info
|
@gotmax23 - i committed your suggested edits. Can you take another look and approve the PR if you agree? |
| state: restarted | ||
|
|
||
| Note that the handlers are triggered if the task as a whole is changed, for loops that is if any loop item changes. | ||
| In the above example both memcached and apache will be restarted if either template file is changed, neither will be restarted if no file changes. |
There was a problem hiding this comment.
Since this behavior is pretty surprising (at least to me, and apparently also to the folks who created the issues in ansible/ansible) I would suggest moving this paragraph before the example, so that you read this before looking at the example. Right now when starting to read this new section, I might just look at the first paragraph and then at the example and then stop, getting the completely wrong impression of what is happening.
| ansible.builtin.template: | ||
| src: "{{ item }}.j2" | ||
| dest: /etc/systemd/system/{{ item }}.service | ||
| notify: Restart {{ item }} |
There was a problem hiding this comment.
I would also add a comment inside the example, like this:
| notify: Restart {{ item }} | |
| # Note: if *any* loop iteration triggers a change, *all* handlers | |
| # for this loop are run! | |
| notify: Restart {{ item }} |
|
Hi @lod We've made some changes to the underlying readthedocs project for this repository. I'm going to close and re-open this issue to kick off a new PR preview build. You might notice there will be two checks for readthedocs. One for The Thank you for your patience and understanding. Also thanks for your contribution to the Ansible documentation. If you have any questions or concerns, please do let us know either here, in the docs channel on Matrix, or in the Ansible forum. Cheers. |
This clarifies behaviour raised in ansible/ansible#81950 and ansible/ansible#77550 as expected and documented.