Skip to content

Commit

Permalink
Bump node to v20
Browse files Browse the repository at this point in the history
No-Issue
  • Loading branch information
himdel committed Jun 18, 2024
1 parent 2444cc0 commit 93217d9
Show file tree
Hide file tree
Showing 11 changed files with 20 additions and 20 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/automerge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ jobs:
- name: "Checkout ansible-hub-ui (${{ github.ref }})"
uses: actions/checkout@v4

- name: "Install node 18"
- name: "Install node 20"
uses: actions/setup-node@v4
with:
node-version: '18'
node-version: '20'

- name: "Check automerge conditions"
working-directory: ".github/workflows"
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/cypress.yml
Original file line number Diff line number Diff line change
Expand Up @@ -109,10 +109,10 @@ jobs:
working-directory: 'oci_env'
run: 'oci-env compose up &'

- name: "Install node 18"
- name: "Install node 20"
uses: actions/setup-node@v4
with:
node-version: '18'
node-version: '20'

- name: "Cache ~/.npm & ~/.cache/Cypress"
uses: actions/cache@v4
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/dev-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ jobs:
- name: "Checkout ansible-hub-ui (${{ github.ref }})"
uses: actions/checkout@v4

- name: "Install node 18"
- name: "Install node 20"
uses: actions/setup-node@v4
with:
node-version: '18'
node-version: '20'

- name: "Update the dev tag"
run: |
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/pr-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ jobs:
- name: "Checkout ansible-hub-ui (${{ github.ref }})"
uses: actions/checkout@v4

- name: "Install node 18"
- name: "Install node 20"
uses: actions/setup-node@v4
with:
node-version: '18'
node-version: '20'
cache: 'npm'

- name: "Checks"
Expand Down Expand Up @@ -88,10 +88,10 @@ jobs:
with:
path: 'pr'

- name: "Install node 18"
- name: "Install node 20"
uses: actions/setup-node@v4
with:
node-version: '18'
node-version: '20'
cache: 'npm'
cache-dependency-path: |
base/package-lock.json
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/stable-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@ jobs:
RELEASE_TAG=`sed 's/^refs\/tags\///' <<< $GITHUB_REF`
echo "RELEASE_TAG=${RELEASE_TAG}" >> $GITHUB_ENV
- name: "Install node 18"
- name: "Install node 20"
uses: actions/setup-node@v4
with:
node-version: '18'
node-version: '20'

- name: "Cache ~/.npm"
uses: actions/cache@v4
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# WARNING
# This Dockerfile is intended for development purposes only. Do not use it for production deployments

FROM node:18-alpine
FROM node:20-alpine
WORKDIR /hub/

RUN mkdir -p /hub/app/ && \
Expand Down
2 changes: 1 addition & 1 deletion build_deploy.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export WORKSPACE=${WORKSPACE:-$APP_ROOT} # if running in jenkins, use the build'
export APP_ROOT=$(pwd)
COMMON_BUILDER=https://raw.githubusercontent.com/RedHatInsights/insights-frontend-builder-common/master

export NODE_BUILD_VERSION=18
export NODE_BUILD_VERSION=20
export IMAGE="quay.io/cloudservices/ansible-hub-ui"

set -exv
Expand Down
2 changes: 1 addition & 1 deletion community/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:18-alpine
FROM node:20-alpine
WORKDIR /workspace/
RUN mkdir -p /workspace/ && \
apk add --no-cache git
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@
"appname": "automation-hub"
},
"engines": {
"node": ">=18",
"npm": ">=9"
"node": ">=20",
"npm": ">=10"
}
}
2 changes: 1 addition & 1 deletion pr_check.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export COMPONENT="automation-hub"
export WORKSPACE=${WORKSPACE:-$APP_ROOT} # if running in jenkins, use the build's workspace
export APP_ROOT=$(pwd)
COMMON_BUILDER=https://raw.githubusercontent.com/RedHatInsights/insights-frontend-builder-common/master
export NODE_BUILD_VERSION=18
export NODE_BUILD_VERSION=20

export APP_NAME="automation-hub" # name of app-sre "application" folder this component lives in
export COMPONENT_NAME="automation-hub" # name of app-sre "resourceTemplate" in deploy.yaml for this component
Expand Down

0 comments on commit 93217d9

Please sign in to comment.