-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose download counts #3880
Merged
Merged
Expose download counts #3880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
backport-4.6
This PR should be backported to stable-4.6 (2.3)
backport-4.7
This PR should be backported to stable-4.7 (2.4)
labels
Jun 21, 2023
himdel
added
community
comunity mode feature
and removed
backport-4.6
This PR should be backported to stable-4.6 (2.3)
labels
Jun 21, 2023
himdel
force-pushed
the
aah22372241
branch
2 times, most recently
from
June 21, 2023 14:25
3d7e41b
to
56cb238
Compare
himdel
force-pushed
the
aah22372241
branch
2 times, most recently
from
June 28, 2023 23:03
104539c
to
56637a2
Compare
himdel
commented
Aug 3, 2023
himdel
force-pushed
the
aah22372241
branch
3 times, most recently
from
August 11, 2023 19:08
de01ce2
to
53cfdeb
Compare
for collections and legacy roles Issue: AAH-2237 Issue: AAH-2241
and reorganize the CollectionHeader page controls to look the same but allow for an extra row and start pulling the collection api in loadCollection and warn about collection count applying to all versions (won't do anything without pulp_ansible#1477)
Backport to stable-4.7: 💚 backport PR created✅ Backport PR branch: Backported as #4127 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
* Expose download counts for collections and legacy roles Issue: AAH-2237 Issue: AAH-2241 * DownloadCount - show number of downloads, use for legacy roles * Collections - use DownloadCount, check insights mode and reorganize the CollectionHeader page controls to look the same but allow for an extra row and start pulling the collection api in loadCollection and warn about collection count applying to all versions (won't do anything without pulp_ansible#1477) * fix title .. show be on the top even if the line gets larger * repositoryBasePath for querying collection api * move collection count to right side of version header (cherry picked from commit 18dfe82)
himdel
added a commit
that referenced
this pull request
Aug 14, 2023
* Expose download counts (#3880) * Expose download counts for collections and legacy roles Issue: AAH-2241 * DownloadCount - show number of downloads, use for legacy roles * Collections - use DownloadCount, check insights mode and reorganize the CollectionHeader page controls to look the same but allow for an extra row and start pulling the collection api in loadCollection and warn about collection count applying to all versions (won't do anything without pulp_ansible#1477) * fix title .. show be on the top even if the line gets larger * repositoryBasePath for querying collection api * move collection count to right side of version header (cherry picked from commit 18dfe82) * remove actuallyCollection, collection download counts not supported in 4.7 * remove insights logic --------- Co-authored-by: Martin Hradil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-4.7
This PR should be backported to stable-4.7 (2.4)
backported-4.7
This PR has been backported to stable-4.7 (2.4)
community
comunity mode feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on ansible/galaxy_ng#1806 (for pulp/pulp_ansible#1477)
Issue: AAH-2237, AAH-2241
Expose download counts in UI
Role detail:
Role list:
Collection detail:
testing...