Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose download counts #3880

Merged
merged 6 commits into from
Aug 14, 2023
Merged

Expose download counts #3880

merged 6 commits into from
Aug 14, 2023

Conversation

himdel
Copy link
Collaborator

@himdel himdel commented Jun 21, 2023

Depends on ansible/galaxy_ng#1806 (for pulp/pulp_ansible#1477)
Issue: AAH-2237, AAH-2241

Expose download counts in UI

Role detail:
20230621013145

Role list:
20230621013449

Collection detail:
20230811191040
20230628225532


testing...

oci-env shell db
insert into ansible_collectiondownloadcount (namespace, name, download_count, pulp_id, pulp_created) values ('arista', 'avd', 456, '0189b769-f75c-76a7-af77-69766bd9b1ca', now());

@github-actions github-actions bot added backport-4.6 This PR should be backported to stable-4.6 (2.3) backport-4.7 This PR should be backported to stable-4.7 (2.4) labels Jun 21, 2023
@himdel himdel added community comunity mode feature and removed backport-4.6 This PR should be backported to stable-4.6 (2.3) labels Jun 21, 2023
@himdel himdel force-pushed the aah22372241 branch 2 times, most recently from 3d7e41b to 56cb238 Compare June 21, 2023 14:25
@himdel himdel removed the backport-4.7 This PR should be backported to stable-4.7 (2.4) label Jun 28, 2023
@himdel himdel force-pushed the aah22372241 branch 2 times, most recently from 104539c to 56637a2 Compare June 28, 2023 23:03
@himdel himdel marked this pull request as ready for review August 2, 2023 22:51
@himdel himdel force-pushed the aah22372241 branch 3 times, most recently from de01ce2 to 53cfdeb Compare August 11, 2023 19:08
for collections and legacy roles

Issue: AAH-2237
Issue: AAH-2241
and reorganize the CollectionHeader page controls to look the same but allow for an extra row
and start pulling the collection api in loadCollection
and warn about collection count applying to all versions

(won't do anything without pulp_ansible#1477)
@himdel himdel merged commit 18dfe82 into ansible:master Aug 14, 2023
17 of 19 checks passed
@himdel himdel deleted the aah22372241 branch August 14, 2023 16:54
@himdel himdel added the backport-4.7 This PR should be backported to stable-4.7 (2.4) label Aug 14, 2023
@patchback
Copy link

patchback bot commented Aug 14, 2023

Backport to stable-4.7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.7/18dfe82d0ecb16ff33613686ecfe956688d5c0a3/pr-3880

Backported as #4127

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 14, 2023
* Expose download counts

for collections and legacy roles

Issue: AAH-2237
Issue: AAH-2241

* DownloadCount - show number of downloads, use for legacy roles

* Collections - use DownloadCount, check insights mode

and reorganize the CollectionHeader page controls to look the same but allow for an extra row
and start pulling the collection api in loadCollection
and warn about collection count applying to all versions

(won't do anything without pulp_ansible#1477)

* fix title .. show be on the top even if the line gets larger

* repositoryBasePath for querying collection api

* move collection count to right side of version header

(cherry picked from commit 18dfe82)
himdel added a commit that referenced this pull request Aug 14, 2023
* Expose download counts (#3880)

* Expose download counts

for collections and legacy roles

Issue: AAH-2241

* DownloadCount - show number of downloads, use for legacy roles

* Collections - use DownloadCount, check insights mode

and reorganize the CollectionHeader page controls to look the same but allow for an extra row
and start pulling the collection api in loadCollection
and warn about collection count applying to all versions

(won't do anything without pulp_ansible#1477)

* fix title .. show be on the top even if the line gets larger

* repositoryBasePath for querying collection api

* move collection count to right side of version header

(cherry picked from commit 18dfe82)

* remove actuallyCollection, collection download counts

not supported in 4.7

* remove insights logic

---------

Co-authored-by: Martin Hradil <[email protected]>
@himdel himdel added the backported-4.7 This PR has been backported to stable-4.7 (2.4) label Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-4.7 This PR should be backported to stable-4.7 (2.4) backported-4.7 This PR has been backported to stable-4.7 (2.4) community comunity mode feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant