Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to avoid spamming syslog with invoked messages #4353

Merged
merged 2 commits into from
Oct 6, 2024
Merged

Fix to avoid spamming syslog with invoked messages #4353

merged 2 commits into from
Oct 6, 2024

Conversation

tanwigeetika1618
Copy link
Contributor

@tanwigeetika1618 tanwigeetika1618 commented Oct 1, 2024 •
edited
Loading

Fix issue #4317

Description

This PR resolves the issue where ansible-basic.py was unnecessarily logging invoked messages to the local syslog, leading to excessive and irrelevant logging during playbook execution.

Changes

  • Modified CustomAnsibleModule in args.py to modify the initialization process.
    -Preventing the unnecessary execution of AnsibleModule.
  • This stops the spamming of syslog with messages such as "ansible-basic.py Invoked with...".

Impact

  • Significantly reduces irrelevant syslog entries.
  • Verified by running ansible-lint and checking logs with journalctl | grep ansible.

@tanwigeetika1618 tanwigeetika1618 requested a review from a team as a code owner October 1, 2024 12:41
@tanwigeetika1618 tanwigeetika1618 requested review from audgirka and alisonlhart and removed request for a team October 1, 2024 12:41
@tanwigeetika1618 tanwigeetika1618 self-assigned this Oct 1, 2024
Qalthos
Qalthos previously requested changes Oct 4, 2024
View reviewed changes
src/ansiblelint/rules/args.py Show resolved Hide resolved
@ssbarnea ssbarnea requested a review from Qalthos October 6, 2024 06:38
@ssbarnea ssbarnea dismissed Qalthos’s stale review October 6, 2024 06:39

Any is ok, for now.

@ssbarnea ssbarnea merged commit a2e4ee5 into ansible:main Oct 6, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

@audgirka audgirka Awaiting requested review from audgirka audgirka is a code owner automatically assigned from ansible/devtools

@alisonlhart alisonlhart Awaiting requested review from alisonlhart alisonlhart is a code owner automatically assigned from ansible/devtools

@Qalthos Qalthos Awaiting requested review from Qalthos

Assignees

@tanwigeetika1618 tanwigeetika1618

Labels
bug
Projects
🧰 devtools project board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tanwigeetika1618 @ssbarnea @Qalthos