-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'labels' to the Helm chart to simplify the declaration of labels #1876
Open
sbilque
wants to merge
7
commits into
ansible:devel
Choose a base branch
from
sbilque:helm_chart_labels
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbilque
force-pushed
the
helm_chart_labels
branch
from
May 28, 2024 09:48
e4cabc7
to
17d7e1d
Compare
sbilque
changed the title
Add 'labels' to the Helm chart to simplify the declaration of labels
Add 'labels' to the Helm chart to simplify the declaration of custom labels
May 28, 2024
sbilque
changed the title
Add 'labels' to the Helm chart to simplify the declaration of custom labels
Add 'labels' to the Helm chart to simplify the declaration of labels
May 28, 2024
Can someone from the community who uses helm give this a try? |
…he reference for the clusterrolebinding'
sbilque
force-pushed
the
helm_chart_labels
branch
from
June 12, 2024 22:46
9ef32b1
to
e50dc12
Compare
rooftopcellist
approved these changes
Jul 3, 2024
@sbilque thank you so much for your contribution! Would you mind rebasing and resolving the merge conflicts? Thank you for your time! |
Quality Gate passedIssues Measures |
auto-merge was automatically disabled
July 26, 2024 15:27
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add
labels
to the Helm chart to simplify the declaration of custom labels.ISSUE TYPE
ADDITIONAL INFORMATION
additional_labels
parameters to be specified in the same values.xml file.Sample of values.xml
Resulting ressources:
Definitions are truncated to make this easier to read.