Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assumerole #24

Open
wants to merge 67 commits into
base: devel
Choose a base branch
from
Open

Add assumerole #24

wants to merge 67 commits into from

Conversation

thedoubl3j
Copy link
Member

Adding in the AWS assume role cred plugin authored by @derekwaters found in this AWX PR.

pyproject.toml Outdated Show resolved Hide resolved
@webknjaz
Copy link
Member

webknjaz commented Aug 29, 2024

@thedoubl3j It should be possible to rebase now. Check what jobs are green on devel and make sure they stay that way in the PR. Currently, that's all the docs jobs. The tests pass, but the jobs are red because of low code coverage.

pyproject.toml Outdated Show resolved Hide resolved
@webknjaz
Copy link
Member

webknjaz commented Sep 4, 2024

FYI, PEP 257-compliant docstrings are always made of triple double-quotes.

.flake8 Outdated Show resolved Hide resolved
.flake8 Outdated Show resolved Hide resolved
.flake8 Outdated Show resolved Hide resolved
.flake8 Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
.flake8 Outdated Show resolved Hide resolved
@webknjaz
Copy link
Member

webknjaz commented Sep 5, 2024

@thedoubl3j plz also add the entry point to the smoke test params @ https://github.com/ansible/awx-plugins/blob/82c8c95/tests/importable_test.py#L27-L73

@webknjaz
Copy link
Member

Rebase this. From now on, all the GHA checks are expected to show up green.

webknjaz and others added 28 commits October 10, 2024 13:56
An alternative would be to add a `from __future__ import annotations` for lazy evaluation.
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
@webknjaz
Copy link
Member

@thedoubl3j this will end up in https://github.com/ansible/awx_plugins.credential.aws_assumerole eventually. That repo doesn't yet have Git history, but it will. Still, it's useful to do an interactive rebase with the commit cleanup here and fix the conflicts. This will help re-graft this branch into the new repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants