Fix extra_vars format and empty value case

[kk-at-redhat]

SUMMARY

For modules inventory, inventory_soruce, group, host and job_template
fixed
variable, extra_vars and source_vars parameters
so that modules while expecting dictionary as an input
push values in yaml format into AAP

Also, fixed edge case when user supplies empty dictionary so that yaml value being pushed into AAP is '---'

related #14918 #14842

ISSUE TYPE

• Bug, Docs Fix or other nominal change

COMPONENT NAME

• Collection

AWX VERSION

4.5.2

ADDITIONAL INFORMATION

Suggested testing.
(01) Create required objects with no variables/extra_vars
(02) Run the following (or similar) tasks

  tasks:
    - ansible.controller.inventory:
        name: "Dynamic A"
        organization: "A"
        variables: {tt: tt, aa: aa}
    
    - ansible.controller.host:
        name: "Host A"
        inventory: "Static A"
        variables: {tt: tt, aa: aa}
    
    - ansible.controller.group:
        name: "Group A"
        inventory: "Static A"
        variables: {tt: tt, aa: aa}

    - ansible.controller.job_template:
        name: "A"
        extra_vars: {tt: tt, aa: aa}

    - ansible.controller.inventory_source:
        name: "A"
        inventory: "Dynamic A"
        source_vars: {tt: tt, aa: aa}

(03) Make sure that variables/extra_vars show right values and formatting in both yaml and json
(04) Run the following:

  tasks:
    - ansible.controller.inventory:
        name: "Dynamic A"
        organization: "A"
        variables: {}
    
    - ansible.controller.host:
        name: "Host A"
        inventory: "Static A"
        variables: {}
    
    - ansible.controller.group:
        name: "Group A"
        inventory: "Static A"
        variables: {}

    - ansible.controller.job_template:
        name: "A"
        extra_vars: {}

    - ansible.controller.inventory_source:
        name: "A"
        inventory: "Dynamic A"
        source_vars: {}

(05) Make sure that variables/extra_vars show right values and formatting in both yaml (---) and json ({})

[fosterseth]

more broadly, is this a problem on awx api side, or unique to awx collection? i.e. even with these changes, is this still an issue with curl/awxkit

[tvo318]

To pass the failures, please fix the following:

• api-lint errors: Json tests not being used since change specifies yaml (please remove the json.dumps(variables))
• awx-collection errors:
  • Test expects a yaml output but gets json: https://github.com/ansible/awx/blob/devel/awx_collection/test/awx/test_group.py#L21C30-L21C64 to https://github.com/ansible/awx/actions/runs/9260939946/job/25565499731?pr=15232#step:4:326. (perhaps the yaml replaced the json file?)
  • Test expects: https://github.com/ansible/awx/blob/devel/awx_collection/test/awx/test_inventory.py#L27
    New result provides: https://github.com/ansible/awx/actions/runs/9260939946/job/25565499731?pr=15232#step:4:416
  • Test expects: https://github.com/ansible/awx/blob/devel/awx_collection/test/awx/test_job_template.py#L28
    New result provides: https://github.com/ansible/awx/actions/runs/9260939946/job/25565499731?pr=15232#step:4:504
• awx_collection_sanity check errors:
  • Error: https://github.com/ansible/awx/actions/runs/9260939946/job/25565496709?pr=15232#step:4:362
    Definition of import must be after documentation and not before it - https://github.com/ansible/awx/pull/15232/files#diff-18ae6f09be9425eb473577cab2cd30a8f7d42ba345e293d7383feff47c6998cbR8 In line 8, must be in line 160 replacing the import json https://github.com/ansible/awx/pull/15232/files#diff-18ae6f09be9425eb473577cab2cd30a8f7d42ba345e293d7383feff47c6998cbR160

[kk-at-redhat]

Thank you. I think that awx_collection errors are expected since this is what the change is about.

@fosterseth as far as I can see API expects yaml, so that's what we should give it through the collection.
If API should be expecting yaml or json - that's outside of the scope IMHO.