Fix for Specifying unified_job_template as ID doesn't work #15255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n't work ansible#14458 Summary: set unified_job_template as value for key id in search_fields if unified_job_template is digit Signed-off-by: Павел Павлов <[email protected]>
github-actions
bot
added
component:awx_collection
fosterseth
reviewed
Jun 5, 2024
| @@ -262,7 +262,10 @@ def main(): | |||
| search_fields['organization'] = module.resolve_name_to_id('organizations', organization) | |||
| unified_job_template_id = None | |||
| if unified_job_template: | |||
| search_fields['name'] = unified_job_template | |||
| if unified_job_template.isdigit(): | |||
There was a problem hiding this comment.
module.get_one has a parameter called name_or_id. Might be better to use that instead
here is an example from a different module
awx/awx_collection/plugins/modules/host.py
Line 105 in 63e82aa
There was a problem hiding this comment.
Hello, thank you for review! I changed code and it use name_or_id now
…n't work ansible#14458 Summary: fix after review, using name_or_id=id parameter Signed-off-by: Павел Павлов <[email protected]>
fosterseth
reviewed
Jun 12, 2024
| @@ -262,8 +262,7 @@ def main(): | |||
| search_fields['organization'] = module.resolve_name_to_id('organizations', organization) | |||
| unified_job_template_id = None | |||
| if unified_job_template: | |||
| search_fields['name'] = unified_job_template | |||
| unified_job_template_id = module.get_one('unified_job_templates', **{'data': search_fields})['id'] | |||
| unified_job_template_id = module.get_one('unified_job_templates', name_or_id=id, **{'data': search_fields})['id'] | |||
There was a problem hiding this comment.
name_or_id=id, -- id isn't a defined variable here
instead I think you want name_or_id=unified_job_template
Also, since search_fields is no longer defined, we don't need to include **{'data': search_fields}
|
also can you provide steps on how you are verifying the change? |
…n't work ansible#14458 Summary: changes after review name_or_id=id changed to name_or_id=unified_jod_template Signed-off-by: Павел Павлов <[email protected]>
…n't work ansible#14458 Summary: remove **{'data': search_fields} Signed-off-by: Павел Павлов <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
related #14458
Summary: set unified_job_template as value for key id in search_fields if
unified_job_template is digit
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION
This issue described at #14458