Fix rrule fast forwarding across DST boundaries #15809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where schedules were not running at the correct time. Details: DST is Daylights Saving Time If the rrule dtstart is "in" a DST period (i.e., March to November) and the current date is outside of the DST, then the fast forwarding is not correct. This is because datetime timedeltas do not honor DST boundaries The Fix: Convert the rrule dtstart to UTC before doing operations. Then, convert back to the original timezone at the end. Signed-off-by: Seth Foster <[email protected]>
|
thedoubl3j
approved these changes
Feb 4, 2025
djyasin
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes an issue where schedules were not running at the correct time.
Details:
DST is Daylight Saving Time
If the rrule dtstart is "in" a DST period (i.e., March to November) and the current date is outside of the DST, then the fast forwarding is not correct.
This is because datetime timedeltas do not honor DST boundaries
The Fix:
Convert the rrule dtstart to UTC before doing operations. Then, convert back to the original timezone at the end.
ISSUE TYPE
COMPONENT NAME