Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass in private_data_dir when project update is on K8S #15866

Open
wants to merge 6 commits into
base: devel
Choose a base branch
from

Conversation

fosterseth
Copy link
Member

@fosterseth fosterseth commented Feb 28, 2025

SUMMARY

pairs with this change ansible/awx_plugins.interfaces#25

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • API

@fosterseth fosterseth force-pushed the fix_incontainer_path branch from 2be5004 to 655253d Compare March 5, 2025 18:09
@fosterseth fosterseth requested review from jessicamack and AlanCoding and removed request for jessicamack March 6, 2025 14:35
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.31%. Comparing base (5b17e5c) to head (8795753).
Report is 2 commits behind head on devel.

✅ All tests successful. No failed tests found.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@AlanCoding AlanCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the background you gave in the plugins patch makes sense to me. I'm still just a little surprised that we're not using /runner, and that this is specific to both OCP and project updates. I don't quite get why it was working that way previously.

Copy link

sonarqubecloud bot commented Mar 6, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants