[HOLD] Only trust last entry in x-forwarded-for by default #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-westcott-iv
force-pushed
the
envoy_x_forwarded_for
branch
from
dc36d45
to
efa253d
Compare
john-westcott-iv
added
the
Ready for review
relrod
reviewed
Aug 22, 2024
| return [value] | ||
| remote_hosts.append(value) | ||
| if get_first_only: | ||
| return [remote_hosts[0]] |
There was a problem hiding this comment.
Are we guaranteed that there's at least one element in remote_hosts here?
There was a problem hiding this comment.
Good call out, we should be because REMOTE_ADDR should always be set. But I'll add a check just incase.
john-westcott-iv
force-pushed
the
envoy_x_forwarded_for
branch
from
efa253d
to
425c777
Compare
|
john-westcott-iv
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.