[HOLD] fix: handle missing RESOURCE_SERVICE_PATH in sync task #624
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an error in eda-server when running the periodic task to sync shared resources:
That is solved by @AlanCoding through ansible/eda-server#1059
Here I just handle the error for the absence of the mandatory param in
get_resource_server_client
. According to the code, this param can not be empty. I wonder if this eventuality should be handled in the constructor:https://github.com/Alex-Izquierdo/django-ansible-base/blob/b7e9271ef7952dddff32d37927a3fa1060515bc6/ansible_base/resource_registry/rest_client.py#L66-L67
Jira: https://issues.redhat.com/browse/AAP-31736