Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD] fix: handle missing RESOURCE_SERVICE_PATH in sync task #624

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

Alex-Izquierdo
Copy link
Contributor

@Alex-Izquierdo Alex-Izquierdo commented Sep 30, 2024

There is an error in eda-server when running the periodic task to sync shared resources:

default-worker.log:Sep 20 18:52:40 ip-10-0-14-133 automation-eda-controller-worker-0[86746]: 2024-09-20 18:52:40,887 aap_eda.tasks.shared_resources ERROR    Failed to sync shared resources. Error: get_resource_server_client() missing 1 required positional argument: 'service_path'

That is solved by @AlanCoding through ansible/eda-server#1059
Here I just handle the error for the absence of the mandatory param in get_resource_server_client. According to the code, this param can not be empty. I wonder if this eventuality should be handled in the constructor:
https://github.com/Alex-Izquierdo/django-ansible-base/blob/b7e9271ef7952dddff32d37927a3fa1060515bc6/ansible_base/resource_registry/rest_client.py#L66-L67

Jira: https://issues.redhat.com/browse/AAP-31736

Copy link

sonarcloud bot commented Sep 30, 2024

Copy link
Member

@AlanCoding AlanCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Earlier failure is always better

@john-westcott-iv john-westcott-iv changed the title fix: handle missing RESOURCE_SERVICE_PATH in sync task [HOLD] fix: handle missing RESOURCE_SERVICE_PATH in sync task Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants