-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vendor django-automated-logging #1794
Vendor django-automated-logging #1794
Conversation
404f7bf
to
aec6431
Compare
Instead of dealing with setup.py and packaging I would simply copy
|
6d033ce
to
265b854
Compare
Minor: It would be nice if the vendored package is placed in a subpackage (e.g. |
Issue: AAH-2388
Issue: AAH-2388
Issue: AAH-2388
Issue: AAH-2388
Issue: AAH-2388
265b854
to
d57cfb5
Compare
Issue: AAH-2388
Issue: AAH-2388
/retest |
1 similar comment
/retest |
Issue: AAH-2388
@cutwater Moved to a subpackage as suggested. |
Tests will be added in a future PR. |
What is this PR doing:
The
django-automated-logging
module we use for api access logging hasn't been touched in ~2 years. It is not Django 4.x compatible. A decision was made to vendor the code to maintain current functionality and not block our Django 4 upgrade.I'm in the process of determining the best way to verify the logging in tests, currently planned for a follow-up PR.
Issue: AAH-2388
Reviewers must know:
When reviewing/testing in oci-env,
PULP_GALAXY_ENABLE_API_ACCESS_LOG=true
must be set in the environment and the resulting log can be inspected with the following commands:Navigating around the app should log CRUD actions as well as username, ip address, and other details. Full details are available in the original jira epic https://issues.redhat.com/browse/AAH-643.