Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export to console.redhat.com #1816

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Export to console.redhat.com #1816

merged 1 commit into from
Oct 11, 2023

Conversation

slemrmartin
Copy link
Contributor

@slemrmartin slemrmartin commented Jul 26, 2023 •
edited
Loading

What is this PR doing:

This feature:

  • adds django command: metrics-collection-automation-analytics
  • renames django command: analytics-export-s3 to metrics-collection-lighspeed.

Both commands collects data from Db, OS and /pulp/api/v3/status/, packs them to 1+ tarballs and:

  • lightspeed: sends it to S3 bucket
  • automation-analytics: uses Red Hat credentials (by default: user name/password) or x-rh-identity header and sends tarballs to console.redhat.com (c.rh.c.) for further processing by Ansible Automation Analytics.

Issue: AA-1757

Reviewers must know:

  • This PR does always full sync of tables. Incremental sync will be added later (Add Support for Dynamic Settings #1837).
  • Feature can be enabled/disabled by settings (see changes)
  • It's intended to be running as an Openshift Job for Galaxy/Cloud Hub.
  • In case of uploading to c.rh.c. it needs cert in "/etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem" for POST to the cloud. It should be part of any AAP installation.

PR Author & Reviewers: Keep or remove backport labels per Backporting Guidelines
Reviewers: Look for sound code, no code smells, docs & test coverage
Merger: When merging, include the Jira issue link in the squashed commit

@slemrmartin slemrmartin marked this pull request as draft July 26, 2023 11:02
@github-actions github-actions bot added backport-4.2 This PR should be backported to stable-4.2 (1.2) backport-4.4 This PR should be backported to stable-4.4 (2.1) backport-4.5 This PR should be backported to stable-4.5 (2.2) backport-4.6 This PR should be backported to stable-4.6 (2.3) backport-4.7 This PR should be backported to stable-4.7 (2.4) labels Jul 26, 2023
@jctanner jctanner removed backport-4.2 This PR should be backported to stable-4.2 (1.2) backport-4.4 This PR should be backported to stable-4.4 (2.1) backport-4.5 This PR should be backported to stable-4.5 (2.2) backport-4.6 This PR should be backported to stable-4.6 (2.3) backport-4.7 This PR should be backported to stable-4.7 (2.4) labels Jul 31, 2023
@rochacbruno
Copy link
Member

@slemrmartin the PR #1837 is ready to review

@slemrmartin slemrmartin force-pushed the analytics-export-ingress branch 2 times, most recently from 387459c to f67f0c8 Compare August 28, 2023 13:14
@slemrmartin slemrmartin changed the title [WIP] Analytics Export to Ingress Analytics Export to Ingress Aug 28, 2023
@slemrmartin slemrmartin marked this pull request as ready for review August 28, 2023 13:29
@slemrmartin slemrmartin changed the title Analytics Export to Ingress Export to console.redhat.com Aug 28, 2023
@slemrmartin slemrmartin force-pushed the analytics-export-ingress branch 8 times, most recently from c1534a6 to 61c7aab Compare August 31, 2023 13:31
@bmclaughlin bmclaughlin self-requested a review August 31, 2023 14:02
@slemrmartin slemrmartin force-pushed the analytics-export-ingress branch 4 times, most recently from 2ad48a4 to e0145a9 Compare September 4, 2023 13:08
@slemrmartin
Automation Analytics Export to Ingress
7549fa6 
It collects db, os and cluster data, packs them to 1+ tarballs and sends
to console.redhat.com, if enabled.
Jira AA-1757

No-Issue

Signed-off-by: Martin Slemr <[email protected]>
@bmclaughlin
Copy link
Contributor

/retest

rochacbruno
rochacbruno reviewed Oct 11, 2023
View reviewed changes
CHANGES/aa-1757.feature
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure our changelog tool can handle this filename, we usually follow the rule AAH-XXXX where issues comes from AAH project.

@jerabekjiri do you know what happens if we have this filename when running changelog builder for release?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: The commit has No-Issue so probably this file is not required.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rochacbruno it will produce incorrect issue and link, but I can fix that in the release.

  `AAH-aa-1757 <https://issues.redhat.com/browse/AAH-aa-1757>`_

rochacbruno
rochacbruno approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@rochacbruno rochacbruno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Added one comment about changelog, but I guess this is not a blocker, maybe we can handle that when it comes to perform a release.

Other detail is that PR #1837 is ready to merge, will probably merge this week

@bmclaughlin bmclaughlin merged commit 998b2ee into ansible:master Oct 11, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rochacbruno rochacbruno rochacbruno approved these changes

@bmclaughlin bmclaughlin bmclaughlin approved these changes

@jctanner jctanner Awaiting requested review from jctanner

@jerabekjiri jerabekjiri Awaiting requested review from jerabekjiri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@slemrmartin @rochacbruno @bmclaughlin @jerabekjiri @jctanner