Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add LegacyRoleImport model to store galaxy-importer logs for legacy imports #1829

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EamonTracey
Copy link
Contributor

@EamonTracey EamonTracey commented Aug 2, 2023

When a legacy role is imported, galaxy-importer calls ansible-lint on the role. Currently, those logs remain unused by galaxy_ng, but ideally, they will be accessible and shown to users when they import a legacy role.

This PR largely mirrors how collection import logs are handled by pulp_ansible. A new LegacyRoleImport model is created for each legacy role import task. A LegacyRoleImportHandler which inherits from logging.Handler will emit all log records into the corresponding LegacyRoleImport model.

@github-actions github-actions bot added backport-4.2 This PR should be backported to stable-4.2 (1.2) backport-4.4 This PR should be backported to stable-4.4 (2.1) backport-4.5 This PR should be backported to stable-4.5 (2.2) backport-4.6 This PR should be backported to stable-4.6 (2.3) backport-4.7 This PR should be backported to stable-4.7 (2.4) labels Aug 2, 2023
@EamonTracey EamonTracey removed backport-4.2 This PR should be backported to stable-4.2 (1.2) backport-4.4 This PR should be backported to stable-4.4 (2.1) backport-4.5 This PR should be backported to stable-4.5 (2.2) backport-4.6 This PR should be backported to stable-4.6 (2.3) backport-4.7 This PR should be backported to stable-4.7 (2.4) labels Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant