Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test for test_x_repo_search_acl_social_user instability in CI #1854

Conversation

jerabekjiri
Copy link
Contributor

@jerabekjiri jerabekjiri commented Aug 29, 2023

No-Issue AAH-2638

https://gist.github.com/jerabekjiri/f05ed52c1f3c1fdb68522f063f98fa1f

The search_url response includes the incremented collection version (autohubtest2.immijnge-1.0.1) in both the staging and published repositories at the same time.
I'm not sure why this is happening, since in https://github.com/ansible/galaxy_ng/blob/01e89102e973c57581d3b6bafca6eb6be1b74080/galaxy_ng/tests/integration/conftest.py#L249C32-L249C32, after the collection is built, it waits for the collection to be in the published repository. Nevertheless, this solution fixes the issue by searching only in the published repository.

@jerabekjiri jerabekjiri force-pushed the fix/unstable-test_x_repo_search_acl_social_user branch 2 times, most recently from 1c5d094 to 2c17981 Compare September 18, 2023 15:49
@jerabekjiri jerabekjiri force-pushed the fix/unstable-test_x_repo_search_acl_social_user branch from c59b35c to 4a527ac Compare September 19, 2023 11:34
Copy link
Collaborator

@jctanner jctanner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find, ty!

@jerabekjiri jerabekjiri merged commit bf4a9fa into ansible:master Sep 19, 2023
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants