fix social auth namespace creation (again) #1937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No-Issue Signed-off-by: James Tanner <[email protected]>
No-Issue Signed-off-by: James Tanner <[email protected]>
No-Issue Signed-off-by: James Tanner <[email protected]>
jctanner
changed the title
jctanner
requested review from
cutwater,
himdel,
rochacbruno,
bmclaughlin,
chr-stian,
appuk,
MilanPospisil,
ShaiahWren and
drodowic
bmclaughlin
reviewed
Oct 17, 2023
| SOCIAL_AUTH_GITHUB_KEY='abcd1234' | ||
| SOCIAL_AUTH_GITHUB_SECRET='abcd1234' | ||
| #SOCIAL_AUTH_GITHUB_KEY='abcd1234' | ||
| #SOCIAL_AUTH_GITHUB_SECRET='abcd1234' |
There was a problem hiding this comment.
Should these lines be removed to reduce confusion?
There was a problem hiding this comment.
tbh, i'm not sure why we have these env files here and also profile specific files in the profiles dir.
bmclaughlin
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The loop that checked for existing users by email was always skipping the checks because it was evaluating the "email" property from github which is usually null.
https://issues.redhat.com/browse/AAH-2787