-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Role import logging #1959
Merged
Merged
Role import logging #1959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
backport-4.2
This PR should be backported to stable-4.2 (1.2)
backport-4.4
This PR should be backported to stable-4.4 (2.1)
backport-4.5
This PR should be backported to stable-4.5 (2.2)
backport-4.6
This PR should be backported to stable-4.6 (2.3)
backport-4.7
This PR should be backported to stable-4.7 (2.4)
backport-4.8
This PR should be backported to stable-4.8 (2.4)
labels
Nov 1, 2023
jctanner
removed
backport-4.2
This PR should be backported to stable-4.2 (1.2)
backport-4.4
This PR should be backported to stable-4.4 (2.1)
backport-4.5
This PR should be backported to stable-4.5 (2.2)
backport-4.6
This PR should be backported to stable-4.6 (2.3)
backport-4.7
This PR should be backported to stable-4.7 (2.4)
backport-4.8
This PR should be backported to stable-4.8 (2.4)
labels
Nov 1, 2023
@geerlingguy any thoughts on this? |
jctanner
requested review from
cutwater,
himdel,
rochacbruno,
bmclaughlin,
MilanPospisil,
ShaiahWren and
drodowic
November 1, 2023 21:05
felixfontein
reviewed
Nov 1, 2023
bmclaughlin
approved these changes
Nov 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once more tests are passing
jctanner
force-pushed
the
ROLE_IMPORT_LOGGING
branch
from
November 5, 2023 15:25
c0503e6
to
73d5da2
Compare
No-Issue Signed-off-by: James Tanner <[email protected]>
jctanner
force-pushed
the
ROLE_IMPORT_LOGGING
branch
from
November 5, 2023 15:26
73d5da2
to
a30ebcd
Compare
No-Issue Signed-off-by: James Tanner <[email protected]>
No-Issue Signed-off-by: James Tanner <[email protected]>
No-Issue Signed-off-by: James Tanner <[email protected]>
No-Issue Signed-off-by: James Tanner <[email protected]>
No-Issue Signed-off-by: James Tanner <[email protected]>
No-Issue Signed-off-by: James Tanner <[email protected]>
No-Issue Signed-off-by: James Tanner <[email protected]>
No-Issue Signed-off-by: James Tanner <[email protected]>
No-Issue Signed-off-by: James Tanner <[email protected]>
No-Issue Signed-off-by: James Tanner <[email protected]>
No-Issue Signed-off-by: James Tanner <[email protected]>
No-Issue Signed-off-by: James Tanner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mimics the collection upload logging architecture in pulp_ansible. Retains compatibility with the CLI ...