Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix github_user and github_repo filters in LegacyRoleImportFilter #1976

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Fix github_user and github_repo filters in LegacyRoleImportFilter #1976

merged 1 commit into from
Nov 15, 2023

Conversation

jerabekjiri
Copy link
Contributor

No-Issue

AttributeError at /api/galaxy/v3/openapi.json
type object 'LegacyRoleImportFilter' has no attribute 'github_user_filter'

In https://github.com/ansible/galaxy_ng/blob/master/galaxy_ng/app/api/v1/filtersets.py#L189 github_user_filter and github_repo_filter are missing filter methods.

Screenshot from 2023-11-14 16-43-09

@github-actions github-actions bot added backport-4.2 This PR should be backported to stable-4.2 (1.2) backport-4.4 This PR should be backported to stable-4.4 (2.1) backport-4.5 This PR should be backported to stable-4.5 (2.2) backport-4.6 This PR should be backported to stable-4.6 (2.3) backport-4.7 This PR should be backported to stable-4.7 (2.4) backport-4.8 This PR should be backported to stable-4.8 (2.4) labels Nov 14, 2023
@jerabekjiri jerabekjiri removed backport-4.2 This PR should be backported to stable-4.2 (1.2) backport-4.4 This PR should be backported to stable-4.4 (2.1) backport-4.5 This PR should be backported to stable-4.5 (2.2) backport-4.6 This PR should be backported to stable-4.6 (2.3) backport-4.7 This PR should be backported to stable-4.7 (2.4) backport-4.8 This PR should be backported to stable-4.8 (2.4) labels Nov 14, 2023
jctanner
jctanner approved these changes Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@jctanner jctanner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jerabekjiri
Copy link
Contributor Author

/retest

@jerabekjiri jerabekjiri merged commit 37a225e into ansible:master Nov 15, 2023
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jctanner jctanner jctanner approved these changes

@rochacbruno rochacbruno Awaiting requested review from rochacbruno

@bmclaughlin bmclaughlin Awaiting requested review from bmclaughlin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jerabekjiri @jctanner