Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(signing):Set signing keys to never expire #2004

Merged
merged 2 commits into from
Dec 11, 2023
Merged

fix(signing):Set signing keys to never expire #2004

merged 2 commits into from
Dec 11, 2023

Conversation

rochacbruno
Copy link
Member

@rochacbruno rochacbruno commented Dec 11, 2023 •
edited
Loading

Edited keys to never expire

No-Issue

For reference

$ gpg --edit-key EBED170E8C9480E22A1D059B15250E9EC0A62577
gpg> expire
# select the option
gpg> save

# do it again for sub key
$ gpg --edit-key EBED170E8C9480E22A1D059B15250E9EC0A62577
gpg> key 1
gpg> expire
# select the option
gpg> save

Reexport

$ gpg --armor --export EBED170E8C9480E22A1D059B15250E9EC0A62577 > dev/common/ansible-sign-pub.txt

$ gpg --output dev/common/ansible-sign-pub.gpg --armor --export EBED170E8C9480E22A1D059B15250E9EC0A62577

$ gpg --output dev/common/ansible-sign.key --armor --export-secret-keys EBED170E8C9480E22A1D059B15250E9EC0A62577

@rochacbruno rochacbruno added backport-4.6 This PR should be backported to stable-4.6 (2.3) backport-4.7 This PR should be backported to stable-4.7 (2.4) backport-4.8 This PR should be backported to stable-4.8 (2.4) backport-4.9 This PR should be backported to stable-4.9 (2.4) labels Dec 11, 2023
@drodowic
Copy link
Collaborator

The ansible-sign.key also needs to be updated in clowd-app.yaml by base64 encoding the file with base64 -w0 dev/common/ansible-sign.key so that it can be used in the ephemeral environments.

bmclaughlin
bmclaughlin approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@bmclaughlin bmclaughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes Error creating signature: Unusable secret key error in logs from expired key

@rochacbruno
Copy link
Member Author

@drodowic I updated the clowder file

@jerabekjiri
Copy link
Contributor

jerabekjiri commented Dec 11, 2023 •
edited
Loading

LGTM
Looks like it failed on test_namespace_management.py::test_namespace_create_and_delete[v3] (https://github.com/ansible/galaxy_ng/actions/runs/7169599469/job/19520365056?pr=2004#step:8:1320), probably not related to this PR, but that test was recently updated in #2000 @chr-stian

@rochacbruno rochacbruno merged commit 141ae4f into ansible:master Dec 11, 2023
20 of 21 checks passed
@rochacbruno rochacbruno deleted the key_fix branch December 11, 2023 17:14
@patchback Patchback
Copy link

patchback bot commented Dec 11, 2023 •
edited
Loading

Backport to stable-4.6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.6/141ae4fb720cadab53c90e5502a7f716fe60d74f/pr-2004

Backported as #2005

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Dec 11, 2023
@rochacbruno @patchback
fix(signing):Set signing keys to never expire (#2004)
1addb2c 
No-Issue

(cherry picked from commit 141ae4f)
@patchback patchback bot mentioned this pull request Dec 11, 2023
Open
@patchback Patchback
Copy link

patchback bot commented Dec 11, 2023 •
edited
Loading

Backport to stable-4.7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.7/141ae4fb720cadab53c90e5502a7f716fe60d74f/pr-2004

Backported as #2006

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Dec 11, 2023
@rochacbruno @patchback
fix(signing):Set signing keys to never expire (#2004)
a26efcc 
No-Issue

(cherry picked from commit 141ae4f)
@patchback patchback bot mentioned this pull request Dec 11, 2023
Merged
@patchback Patchback
Copy link

patchback bot commented Dec 11, 2023 •
edited
Loading

Backport to stable-4.8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.8/141ae4fb720cadab53c90e5502a7f716fe60d74f/pr-2004

Backported as #2007

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Dec 11, 2023
@rochacbruno @patchback
fix(signing):Set signing keys to never expire (#2004)
4bfb585 
No-Issue

(cherry picked from commit 141ae4f)
@patchback patchback bot mentioned this pull request Dec 11, 2023
Merged
@patchback Patchback
Copy link

patchback bot commented Dec 11, 2023 •
edited
Loading

Backport to stable-4.9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.9/141ae4fb720cadab53c90e5502a7f716fe60d74f/pr-2004

Backported as #2008

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Dec 11, 2023
@rochacbruno @patchback
fix(signing):Set signing keys to never expire (#2004)
8520587 
No-Issue

(cherry picked from commit 141ae4f)
@patchback patchback bot mentioned this pull request Dec 11, 2023
Merged
rochacbruno added a commit that referenced this pull request Dec 11, 2023
@patchback @rochacbruno
[PR #2004/141ae4fb backport][stable-4.8] fix(signing):Set signing key…
4d2e237 
…s to never expire (#2007)

fix(signing):Set signing keys to never expire (#2004)

No-Issue

(cherry picked from commit 141ae4f)

Co-authored-by: Bruno Rocha <[email protected]>
rochacbruno added a commit that referenced this pull request Dec 11, 2023
@patchback @rochacbruno
[PR #2004/141ae4fb backport][stable-4.7] fix(signing):Set signing key…
1bcb018 
…s to never expire (#2006)

fix(signing):Set signing keys to never expire (#2004)

No-Issue

(cherry picked from commit 141ae4f)

Co-authored-by: Bruno Rocha <[email protected]>
rochacbruno added a commit that referenced this pull request Dec 11, 2023
@patchback @rochacbruno
[PR #2004/141ae4fb backport][stable-4.9] fix(signing):Set signing key…
806413c 
…s to never expire (#2008)

fix(signing):Set signing keys to never expire (#2004)

No-Issue

(cherry picked from commit 141ae4f)

Co-authored-by: Bruno Rocha <[email protected]>
himdel added a commit to himdel/ansible-hub-ui that referenced this pull request Dec 11, 2023
@himdel
CI: update signing key for testing signing
e6c6488 
ansible/galaxy_ng#2004
@himdel himdel mentioned this pull request Dec 11, 2023
Merged
himdel added a commit to ansible/ansible-hub-ui that referenced this pull request Dec 11, 2023
@himdel
CI: update signing key for testing signing (#4683)
be27af6 
ansible/galaxy_ng#2004
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmclaughlin bmclaughlin bmclaughlin approved these changes

@himdel himdel Awaiting requested review from himdel

@jctanner jctanner Awaiting requested review from jctanner

@chr-stian chr-stian Awaiting requested review from chr-stian

@jerabekjiri jerabekjiri Awaiting requested review from jerabekjiri

Assignees
No one assigned
Labels
backport-4.6 This PR should be backported to stable-4.6 (2.3) backport-4.7 This PR should be backported to stable-4.7 (2.4) backport-4.8 This PR should be backported to stable-4.8 (2.4) backport-4.9 This PR should be backported to stable-4.9 (2.4)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rochacbruno @drodowic @jerabekjiri @bmclaughlin