Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for galaxy operator #2058

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

aknochow
Copy link
Member

@aknochow aknochow commented Feb 2, 2024

  1. Updating Dockerfile to install required directories in /var/lib/pulp/
  2. Adding skopeo dnf dependency for content signing script
  3. Adding readyz.py for galaxy-operator ready check

depends-on: ansible/galaxy-operator#17

'No-Issue'

galaxy-operator/bin/wait_on_postgres.py Outdated Show resolved Hide resolved
Dockerfile.rhel8 Show resolved Hide resolved
@aknochow aknochow force-pushed the add-galaxy-operator-support branch 7 times, most recently from 5558e25 to 1efc3ef Compare February 6, 2024 20:28
Copy link
Member

@rooftopcellist rooftopcellist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changeset looks good.

Idea: I think we might want to think about adding a "configure-signing-services.sh" for the initContainer to use in a future PR to make the operator codebase a bit cleaner.

But a PR for another day.

1. Updating Dockerfile to install required directories in /var/lib/pulp/
2. Adding skopeo dnf dependency for content signing script
3. Adding readyz.py for galaxy-operator ready check
4. Updating MANIFEST.in

No-Issue
@rooftopcellist
Copy link
Member

rooftopcellist commented Feb 8, 2024

@himdel @drodowic @jctanner It looks all of the CI issues pertaining to this PR have been fixed. But the Galaxy CI checks are all failing due to an unrelated problem now when building the image:

    7.066 ERROR: Package 'galaxy-ng' requires a different Python: 3.8.17 not in '>=3.9'
    ------
    Containerfile:8
    --------------------
       6 |     # Install python packages
       7 |
       8 | >>> RUN pip3 install ./galaxy_ng

I see this in other PR's as well for example:

I see this change was made recently... but it is already included in this branch, no need to rebase.

Any suggestions on this issue?

@rooftopcellist
Copy link
Member

It appears that the base image used by CI when building has python3.8.17, and python3.9+ is required.

[chadams@awx galaxy_ng]$ docker run -it ghcr.io/pulp/pulp-ci-centos bash

[root@2bfd2acc2a67 /]# python3 --version
Python 3.8.17

@drodowic drodowic merged commit f6619a1 into ansible:master Feb 9, 2024
17 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants