Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to override the gunicorn path in start scripts #2080

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

rooftopcellist
Copy link
Member

No-Issue

What is this PR doing:

Make it possible to override the gunicorn path in the entrypoint command invocation.

readonly GUNICORN="${GUNICORN:-'/venv/bin/gunicorn'}"

It looks like gunicorn is not called with the full path in the content:

And the worker doesn't seem to have any reference of gunicorn:

So I think it's just start-api and start-api-reload we need to worry about

Reviewers must know:

PR Author & Reviewers: Keep or remove backport labels per Backporting Guidelines
Reviewers: Look for sound code, no code smells, docs & test coverage
Merger: When merging, include the Jira issue link in the squashed commit

Copy link
Collaborator

@jctanner jctanner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

start-content and start-content-reload should have these changes too.

@rooftopcellist
Copy link
Member Author

This PR is ready to merge afaik. Please merge it when possible, thanks!

@jctanner jctanner merged commit d0bf488 into ansible:master Feb 23, 2024
18 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants