Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load required settings from django-ansible-base if not set. #2176

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Load required settings from django-ansible-base if not set. #2176

merged 2 commits into from
Jun 18, 2024

Conversation

rochacbruno
Copy link
Member

@rochacbruno rochacbruno commented Jun 17, 2024 •
edited
Loading

No-Issue
Related: AAP-25505

@github-actions github-actions bot added backport-4.2 This PR should be backported to stable-4.2 (1.2) backport-4.4 This PR should be backported to stable-4.4 (2.1) backport-4.5 This PR should be backported to stable-4.5 (2.2) backport-4.6 This PR should be backported to stable-4.6 (2.3) backport-4.7 This PR should be backported to stable-4.7 (2.4) backport-4.8 This PR should be backported to stable-4.8 (2.4) backport-4.9 This PR should be backported to stable-4.9 (2.4) labels Jun 17, 2024
@rochacbruno rochacbruno removed backport-4.2 This PR should be backported to stable-4.2 (1.2) backport-4.4 This PR should be backported to stable-4.4 (2.1) backport-4.5 This PR should be backported to stable-4.5 (2.2) backport-4.6 This PR should be backported to stable-4.6 (2.3) backport-4.7 This PR should be backported to stable-4.7 (2.4) backport-4.8 This PR should be backported to stable-4.8 (2.4) backport-4.9 This PR should be backported to stable-4.9 (2.4) labels Jun 17, 2024
@rochacbruno rochacbruno mentioned this pull request Jun 17, 2024
Closed
@jctanner
Copy link
Collaborator

What exactly will this help resolve? I get the idea, but I'm not sure why and there's no test to spell it out for me.

@rochacbruno
Copy link
Member Author

@jctanner AAP-25505 is a bug saying that settings.ANSIBLE_BASE_XYZ was not found

@rochacbruno
Add test
72c8421 
No-Issue
@rochacbruno rochacbruno mentioned this pull request Jun 17, 2024
Closed
@rochacbruno
Copy link
Member Author

@jctanner I added a test case

jctanner
jctanner approved these changes Jun 17, 2024
View reviewed changes
Copy link
Collaborator

@jctanner jctanner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can try it. I'm concerned the content of ansible_base/lib/dynamic_config/dynamic_settings.py won't be kept sane for all galaxy deployments, but don't currently have any thing specific in mind

@rochacbruno rochacbruno merged commit 2986b15 into ansible:master Jun 18, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jctanner jctanner jctanner approved these changes

@newswangerd newswangerd newswangerd approved these changes

Assignees
No one assigned
Labels
multi-commit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rochacbruno @jctanner @newswangerd