Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the JWT hook that overrides hostname and content origin. #2181

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Remove the JWT hook that overrides hostname and content origin. #2181

merged 2 commits into from
Jun 19, 2024

Conversation

jctanner
Copy link
Collaborator

@jctanner jctanner commented Jun 19, 2024 •
edited
Loading

This hook is too broad and conflicts with the intent of the alter_hostname_settings hook ...

https://github.com/ansible/galaxy_ng/blob/master/galaxy_ng/app/dynaconf_hooks.py#L714-L742

https://issues.redhat.com/browse/AAP-25573

@github-actions github-actions bot added backport-4.2 This PR should be backported to stable-4.2 (1.2) backport-4.4 This PR should be backported to stable-4.4 (2.1) backport-4.5 This PR should be backported to stable-4.5 (2.2) backport-4.6 This PR should be backported to stable-4.6 (2.3) backport-4.7 This PR should be backported to stable-4.7 (2.4) backport-4.8 This PR should be backported to stable-4.8 (2.4) backport-4.9 This PR should be backported to stable-4.9 (2.4) labels Jun 19, 2024
@jctanner jctanner removed backport-4.2 This PR should be backported to stable-4.2 (1.2) backport-4.4 This PR should be backported to stable-4.4 (2.1) backport-4.5 This PR should be backported to stable-4.5 (2.2) backport-4.6 This PR should be backported to stable-4.6 (2.3) backport-4.7 This PR should be backported to stable-4.7 (2.4) backport-4.8 This PR should be backported to stable-4.8 (2.4) backport-4.9 This PR should be backported to stable-4.9 (2.4) labels Jun 19, 2024
@jctanner @rochacbruno
Lint fix.
325cef1 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@rochacbruno rochacbruno enabled auto-merge (squash) June 19, 2024 12:43
@rochacbruno rochacbruno merged commit fd4b91a into ansible:master Jun 19, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rochacbruno rochacbruno rochacbruno approved these changes

@brsanche brsanche brsanche approved these changes

Assignees
No one assigned
Labels
multi-commit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jctanner @rochacbruno @brsanche