Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rewrite _ui/v2/users/ and add more test coverage #2229

Merged
merged 13 commits into from
Aug 19, 2024
Merged

rewrite _ui/v2/users/ and add more test coverage #2229

merged 13 commits into from
Aug 19, 2024

Conversation

jctanner
Copy link
Collaborator

@jctanner jctanner commented Aug 16, 2024 •
edited
Loading

@github-actions github-actions bot added backport-4.2 This PR should be backported to stable-4.2 (1.2) backport-4.4 This PR should be backported to stable-4.4 (2.1) backport-4.5 This PR should be backported to stable-4.5 (2.2) backport-4.6 This PR should be backported to stable-4.6 (2.3) backport-4.7 This PR should be backported to stable-4.7 (2.4) backport-4.8 This PR should be backported to stable-4.8 (2.4) backport-4.9 This PR should be backported to stable-4.9 (2.4) labels Aug 16, 2024
@jctanner
Checkin.
b09ec73 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
It's ugly but it's kinda working atm.
78e854e 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
Checkin.
dec60da 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
All but email validation working.
9520092 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
All tests passing now, must cleanup.
9a095c9 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
Cleaned up, just need to add email validation.
1454fcc 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
Don't allow empty passwords.
0b12c2a 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
All tests passing so far.
4408157 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner jctanner removed backport-4.2 This PR should be backported to stable-4.2 (1.2) backport-4.4 This PR should be backported to stable-4.4 (2.1) backport-4.5 This PR should be backported to stable-4.5 (2.2) backport-4.6 This PR should be backported to stable-4.6 (2.3) backport-4.7 This PR should be backported to stable-4.7 (2.4) backport-4.8 This PR should be backported to stable-4.8 (2.4) backport-4.9 This PR should be backported to stable-4.9 (2.4) multi-commit labels Aug 18, 2024
@jctanner
More negative testing and validation.
510b6b8 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner jctanner changed the title Fix user PUTs and make emails+passwords fully optional. Complete rewrite of _ui/v2/users/ to including testing Aug 18, 2024
@jctanner
Add user to group when added to team.
02b66b1 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner jctanner changed the title Complete rewrite of _ui/v2/users/ to including testing rewrite _ui/v2/users/ to including testing Aug 18, 2024
@jctanner jctanner changed the title rewrite _ui/v2/users/ to including testing rewrite _ui/v2/users/ and thorough tests Aug 18, 2024
@jctanner
Handle group/team/org membership on PUT/PATCH.
f9b7b14 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
Update test docstrings.
99d4c0b 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner jctanner changed the title rewrite _ui/v2/users/ and thorough tests rewrite _ui/v2/users/ and add more test coverage Aug 19, 2024
@jctanner
Copy link
Collaborator Author

failing rbac tests are flaky, they pass locally.

@jctanner jctanner merged commit ec75780 into ansible:master Aug 19, 2024
17 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
multi-commit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jctanner