Random Bug fixes

[willtome]

No description provided.

[youtous]

@willtome I have removed the Ansible-lint gh action and replaced it by pre-commit action.
The bug on the ansible-lint action that is preventing us to reference a specific version of the ansible-lint component is referenced by (ansible/ansible-lint#3830)

Using pre-commit as a single point of entry for the linting will ensure consistency for developments (locally and in the CI).

I have referenced the variable naming issue in #120, it will be treated as a separate PR.

Waiting for your review ;)

[jce-redhat]

Note: the YAML linter complains when comments aren't indented at the same level as the YAML item, which causes some of the lint issues. this should be configurable in the .yamllint config file, see about disabling this particular feature.

[jce-redhat]

LGTM with one overall comment. the roles that are under collections/ansible_collections/demo/compliance/ are copies of DISA-provided roles available from the DISA website. any time they get updated it may introduce more things that ansible-lint doesn't like, so we really shouldn't be linting them. that directory is supposed to be excluded in the ansible-lint config file, so i'm not sure why it would have complained.

since they're not content created for product-demos, we should probably move all of the roles out of collections/ and into roles/ as well, and update .ansible-lint appropriately.

[jce-redhat]

Note: the YAML linter complains when comments aren't indented at the same level as the YAML item, which causes some of the lint issues. this should be configurable in the .yamllint config file, see about disabling this particular feature.

that is, disable comments-indentation

[youtous]

TODO:

• exclude content that is 3rd dep from lint
• see if comment-indentation for yaml should be disabled: @jce-redhat, what is the rationale behind this?

thank you for the reviews and the comments

[IPvSean]

I am good with this

[jce-redhat]

* [ ]  see if comment-indentation for yaml should be disabled: @jce-redhat, what is the rationale behind this?

the ansible-lint action was complaining about a couple of files where a block of YAML items was commented out, such as this:

product-demos/collections/ansible_collections/demo/patching/plugins/modules/win_scan_packages.py

Line 14 in d5093fa

# Example fact output:

this seems to be more of an issue with YAML embedded in python code rather than ansible tasks. by setting comments-indentation: disable set we can get past those action failures for now until the code gets cleaned up.

[jce-redhat]

@youtous for your TODOs, i opened #122 for the first one, and you could add the yamllint config change to #119 since it builds on this PR.