Workaround for #109 #123
Workaround for #109 #123
Conversation
|
@youtous could you take a look at the error in the CI? |
|
I've re-run the CI, it was failing due to 504 on console.redhat.com, now it works. |
windows/powershell_dsc.yml
Outdated
| ansible.windows.win_powershell: | ||
| script: | | ||
| $nuget_version = (Get-PackageProvider -Name NuGet -ListAvailable).version | ||
| $nuget_target_version = '2.8.5.201' |
There was a problem hiding this comment.
for proper version comparison, should this be something like $nuget_target_version = [Version]::new('2.8.5.201') instead? i ask as someone with no powershell proficiency, but i've seen version comparisons get strange with standard greater/less than operators in bash before so i thought i'd look for a powershell example. i'm not sure if specifying the variable as a Version type would cause issues with the Install-PackageProvider call below this.
There was a problem hiding this comment.
PowerShell is typically smart enough to do the conversion on the fly by I don't have an issue hard typing it.
There was a problem hiding this comment.
addressed in latest push
There was a problem hiding this comment.
thanks @MKletz, if you're feeling good about the version comparison change then everything else looks fine to me.
yup should be all good |
This is a workaround for #109
This should not be the permanent fix as the first task would need replicated in any playbook installing additional PowerShell modules. These additional settings should be configured on the VM at provisioning time. However this will get it functional in the short term.