-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Compliance Workflow #219
base: main
Are you sure you want to change the base?
Conversation
linux/compliance.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think we should remove this playbook/job template, because it is meant to demo something slightly different than the multi-compliance demo. this one uses the DISA supplemental content, which among other things runs much faster than the ComplianceAsCode roles, so a) it allows folks to talk to multiple options for compliance content, and b) as it is faster this job can be run live in a short period of time, unlike the multi-compliance demo which takes much longer.
this will have a cascading effect, anywhere else where the related job template is changed/removed, those changes will need to be undone as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's fine I was just confused why there seemed to be duplicated.
collections/ansible_collections/demo/cloud/roles/aws/tasks/resize_ec2.yml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good. is the instance resize still part of the new compliance workflow?
These are some simple additions to the Linux / Compliance jobs we already have: