-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rhc system role implemention #70
base: main
Are you sure you want to change the base?
Conversation
What do we need to do in the rhc system role for that?
Not sure what you mean by "the insights collection". The latest upstream release of the rhc role has the fix for the insights tagging - https://github.com/linux-system-roles/rhc/releases/tag/1.1.3 - and this is also in Galaxy - https://galaxy.ansible.com/linux-system-roles/rhc - and in the latest system roles collection - https://galaxy.ansible.com/fedora/linux_system_roles If you mean Automation Hub then we're working on it - no ETA yet. |
@richm Thanks for the comment. You read my mind. The error blocking this PR is the insights tagging. Once that is pushed to Hub this PR will be ready for review. This project previously used the redhat.insights collection for registering hosts. With that functionality now part of the rhc role I wanted to migrate to that as the best practice for managing host registration. Does the rhc role also support registration to Satellite? If so, perhaps that should be part of this PR as well. If you would like to test:
Would appreciate any feedback you have on how to best implement and demonstrate the role as it was intended to be used. |
@ptoscano see #70 (comment) - not sure if the |
Hi @willtome, nice to see the progress :) (for more general context: Will and me talked few days about about this & the insights collection)
Most likely it can be set manually in the configuration of
It does: either you need to set the various Also, note that the role enables additional Insights bits by default, i.e. currently the remediation. So if they are not needed for this demo, I suggest disabling them (or only those not need): rhc_insights:
remediation: absent Nice job, looks slick! |
@willtome any update on this before you head out? |
Few months later, a good update on this. Version 1.23.0 of the rhc_insights:
display_name: "{{ inventory_hostname }}" @willtome would you have time to update this work, and give it a try? Thanks! |
Migrate from the insights collection and community module to the rhc system role. Display name functionality is lost. Needs a workaround.
This PR is blocked until the next release of the insights collection because tags are not working due to incorrect (cc: @richm)