Catch up commit to installer... by NickJLange · Pull Request #10 · ansible/role-install-gcloud

NickJLange · 2025-09-02T02:28:58Z

No description provided.

Copilot

Pull Request Overview

This PR refactors the Google Cloud SDK installation from a manual archive-based approach to using the official APT repository, and adds authentication configuration functionality.

Replaced manual download/extract installation with APT package manager installation
Added Google Cloud authentication using service account credentials
Introduced new configuration templates and authentication tasks

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
defaults/main.yml	Updated default variables for APT-based installation and added keyring configuration
tasks/main.yml	Completely rewritten to use APT repository installation and authentication
tasks/raw_install.yml	New file containing the original manual installation approach
tasks/authenticate.yml	New authentication task file with credential setup
vars/main.yml	Added credentials file variable
templates/default_config.j2	New template for default gcloud configuration
files	Added symbolic link to shared files directory

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-02T02:30:12Z

tasks/authenticate.yml

+        mode: 0600
+    - name: Authenticate with Google Cloud
+      ansible.builtin.shell: 
+        cmd: "gcloud auth login --creds-file=/home/njl/.config/gcloud/{{ gcloud_credentials }}"


The flag --creds-file is incorrect. The correct flag for gcloud auth login with service account credentials is --cred-file (singular).

Suggested change

cmd: "gcloud auth login --creds-file=/home/njl/.config/gcloud/{{ gcloud_credentials }}"

cmd: "gcloud auth login --cred-file=/home/njl/.config/gcloud/{{ gcloud_credentials }}"

Copilot · 2025-09-02T02:30:13Z

tasks/main.yml

+        mode: "0600"
+    - name: Authenticate with Google Cloud
+      ansible.builtin.shell:
+        cmd: "gcloud auth login --cred-file=/home/njl/.config/gcloud/{{ gcloud_credentials }}"


For service account authentication, use gcloud auth activate-service-account --key-file instead of gcloud auth login --cred-file. The login command is for user authentication, not service accounts.

Suggested change

cmd: "gcloud auth login --cred-file=/home/njl/.config/gcloud/{{ gcloud_credentials }}"

cmd: "gcloud auth activate-service-account --key-file=/home/njl/.config/gcloud/{{ gcloud_credentials }}"

Copilot · 2025-09-02T02:30:13Z

tasks/main.yml

+        name: "/home/njl/.config/gcloud/"
+        state: directory
+        mode: "0700"
+    - name: Copy the archive from the Ansible controller
+      ansible.builtin.copy:
+        src: "{{ gcloud_credentials }}"
+        dest: "/home/njl/.config/gcloud/{{ gcloud_credentials }}"
+        mode: "0600"
+    - name: Authenticate with Google Cloud
+      ansible.builtin.shell:
+        cmd: "gcloud auth login --cred-file=/home/njl/.config/gcloud/{{ gcloud_credentials }}"


Hard-coded path '/home/njl' should be replaced with a variable like {{ ansible_env.HOME }} or {{ local_ssh_user_home }} to make the role more reusable.

Suggested change

name: "/home/njl/.config/gcloud/"

state: directory

mode: "0700"

- name: Copy the archive from the Ansible controller

ansible.builtin.copy:

src: "{{ gcloud_credentials }}"

dest: "/home/njl/.config/gcloud/{{ gcloud_credentials }}"

mode: "0600"

- name: Authenticate with Google Cloud

ansible.builtin.shell:

cmd: "gcloud auth login --cred-file=/home/njl/.config/gcloud/{{ gcloud_credentials }}"

name: "{{ ('~' + local_ssh_user + '/.config/gcloud/') | expanduser }}"

state: directory

mode: "0700"

- name: Copy the archive from the Ansible controller

ansible.builtin.copy:

src: "{{ gcloud_credentials }}"

dest: "{{ ('~' + local_ssh_user + '/.config/gcloud/' + gcloud_credentials) | expanduser }}"

mode: "0600"

- name: Authenticate with Google Cloud

ansible.builtin.shell:

cmd: "gcloud auth login --cred-file={{ ('~' + local_ssh_user + '/.config/gcloud/' + gcloud_credentials) | expanduser }}"

Copilot · 2025-09-02T02:30:13Z

tasks/main.yml

+        name: "/home/njl/.config/gcloud/"
+        state: directory
+        mode: "0700"
+    - name: Copy the archive from the Ansible controller
+      ansible.builtin.copy:
+        src: "{{ gcloud_credentials }}"
+        dest: "/home/njl/.config/gcloud/{{ gcloud_credentials }}"
+        mode: "0600"
+    - name: Authenticate with Google Cloud
+      ansible.builtin.shell:
+        cmd: "gcloud auth login --cred-file=/home/njl/.config/gcloud/{{ gcloud_credentials }}"


Hard-coded path '/home/njl' should be replaced with a variable like {{ ansible_env.HOME }} or {{ local_ssh_user_home }} to make the role more reusable.

Suggested change

name: "/home/njl/.config/gcloud/"

state: directory

mode: "0700"

- name: Copy the archive from the Ansible controller

ansible.builtin.copy:

src: "{{ gcloud_credentials }}"

dest: "/home/njl/.config/gcloud/{{ gcloud_credentials }}"

mode: "0600"

- name: Authenticate with Google Cloud

ansible.builtin.shell:

cmd: "gcloud auth login --cred-file=/home/njl/.config/gcloud/{{ gcloud_credentials }}"

name: "{{ local_ssh_user_home }}/.config/gcloud/"

state: directory

mode: "0700"

- name: Copy the archive from the Ansible controller

ansible.builtin.copy:

src: "{{ gcloud_credentials }}"

dest: "{{ local_ssh_user_home }}/.config/gcloud/{{ gcloud_credentials }}"

mode: "0600"

- name: Authenticate with Google Cloud

ansible.builtin.shell:

cmd: "gcloud auth login --cred-file={{ local_ssh_user_home }}/.config/gcloud/{{ gcloud_credentials }}"

Copilot · 2025-09-02T02:30:14Z

tasks/authenticate.yml

+        dest: "/home/njl/.config/gcloud/{{ gcloud_credentials }}"
+        mode: 0600
+    - name: Authenticate with Google Cloud
+      ansible.builtin.shell: 
+        cmd: "gcloud auth login --creds-file=/home/njl/.config/gcloud/{{ gcloud_credentials }}"


Hard-coded path '/home/njl' should be replaced with a variable to make the authentication task reusable across different users.

Suggested change

dest: "/home/njl/.config/gcloud/{{ gcloud_credentials }}"

mode: 0600

- name: Authenticate with Google Cloud

ansible.builtin.shell:

cmd: "gcloud auth login --creds-file=/home/njl/.config/gcloud/{{ gcloud_credentials }}"

dest: "{{ ansible_env.HOME }}/.config/gcloud/{{ gcloud_credentials }}"

mode: 0600

- name: Authenticate with Google Cloud

ansible.builtin.shell:

cmd: "gcloud auth login --creds-file={{ ansible_env.HOME }}/.config/gcloud/{{ gcloud_credentials }}"

Copilot · 2025-09-02T02:30:14Z

tasks/authenticate.yml

+        dest: "/home/njl/.config/gcloud/{{ gcloud_credentials }}"
+        mode: 0600
+    - name: Authenticate with Google Cloud
+      ansible.builtin.shell: 
+        cmd: "gcloud auth login --creds-file=/home/njl/.config/gcloud/{{ gcloud_credentials }}"


Hard-coded path '/home/njl' should be replaced with a variable to make the authentication task reusable across different users.

Suggested change

dest: "/home/njl/.config/gcloud/{{ gcloud_credentials }}"

mode: 0600

- name: Authenticate with Google Cloud

ansible.builtin.shell:

cmd: "gcloud auth login --creds-file=/home/njl/.config/gcloud/{{ gcloud_credentials }}"

dest: "{{ ansible_env.HOME }}/.config/gcloud/{{ gcloud_credentials }}"

mode: 0600

- name: Authenticate with Google Cloud

ansible.builtin.shell:

cmd: "gcloud auth login --creds-file={{ ansible_env.HOME }}/.config/gcloud/{{ gcloud_credentials }}"

Copilot · 2025-09-02T02:30:14Z

templates/default_config.j2

+account = nick.lange@gmail.com
+project = zeta-environs-173316


Hard-coded email and project values should be replaced with variables like {{ gcloud_account }} and {{ gcloud_project }} to make the template configurable.

Suggested change

account = nick.lange@gmail.com

project = zeta-environs-173316

account = {{ gcloud_account }}

project = {{ gcloud_project }}

Copilot · 2025-09-02T02:30:15Z

tasks/raw_install.yml

@@ -0,0 +1,86 @@
+---
+  - block:
+    - name: Insure temp path exists


Spelling error: 'Insure' should be 'Ensure' in the task name.

Suggested change

- name: Insure temp path exists

- name: Ensure temp path exists

NickJLange added 3 commits September 14, 2020 09:26

Catch up commit - not sure this is a good change

c7cd5df

November Catchup Commit

86a080b

Updates to installer for a better experience of setting up nodes

1779aa9

Copilot AI review requested due to automatic review settings September 2, 2025 02:28

Copilot AI reviewed Sep 2, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Catch up commit to installer...#10

Catch up commit to installer...#10
NickJLange wants to merge 3 commits intoansible:masterfrom
NickJLange:fancy_fixes

NickJLange commented Sep 2, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Sep 2, 2025

Uh oh!

Copilot AI Sep 2, 2025

Uh oh!

Copilot AI Sep 2, 2025

Uh oh!

Copilot AI Sep 2, 2025

Uh oh!

Copilot AI Sep 2, 2025

Uh oh!

Copilot AI Sep 2, 2025

Uh oh!

Copilot AI Sep 2, 2025

Uh oh!

Copilot AI Sep 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	cmd: "gcloud auth login --creds-file=/home/njl/.config/gcloud/{{ gcloud_credentials }}"
	cmd: "gcloud auth login --cred-file=/home/njl/.config/gcloud/{{ gcloud_credentials }}"

	cmd: "gcloud auth login --cred-file=/home/njl/.config/gcloud/{{ gcloud_credentials }}"
	cmd: "gcloud auth activate-service-account --key-file=/home/njl/.config/gcloud/{{ gcloud_credentials }}"

		account = nick.lange@gmail.com
		project = zeta-environs-173316

	- name: Insure temp path exists
	- name: Ensure temp path exists

Conversation

NickJLange commented Sep 2, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 2, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants