Fix implementation of no_context #2215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #2215 +/- ##
==========================================
- Coverage 84.03% 84.01% -0.03%
==========================================
Files 90 90
Lines 10313 10308 -5
==========================================
- Hits 8667 8660 -7
- Misses 1646 1648 +2 |
a-bouth
reviewed
Apr 15, 2025
|
@cbellot000 please complete the PR description with minimum information on what this PR's about |
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing DPF to start without a context had been exposed in pydpf. This wasn't working at all because: the enum created (LicensingContextType.none) had no meaning server side. The effect of using no_context was: dpf default initialization was done, loading most plugins.
With this PR, applying no context is done by using a "eUserDefinedContext"==2 and putting an empty xml path -> no xml.