Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Reduce via in bounding box #946

Merged
merged 7 commits into from
Dec 19, 2024
Merged

FEAT: Reduce via in bounding box #946

merged 7 commits into from
Dec 19, 2024

Conversation

boyang2022
Copy link
Collaborator

@boyang2022 boyang2022 commented Dec 16, 2024

This new feature reduced the number of vias inside a bounding box

@github-actions github-actions bot added the grpc-transition Changes that need to be included in gRPC transition label Dec 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.69%. Comparing base (f20b61e) to head (91008fc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #946      +/-   ##
==========================================
+ Coverage   82.67%   82.69%   +0.02%     
==========================================
  Files         160      160              
  Lines       21098    21117      +19     
==========================================
+ Hits        17442    17462      +20     
+ Misses       3656     3655       -1     

Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test

@github-actions github-actions bot added the testing Anything related to testing label Dec 17, 2024
@svandenb-dev
Copy link
Collaborator

@boyang2022 please fix the conflicts then we can merge.

# Conflicts:
#	src/pyedb/dotnet/edb_core/padstack.py
#	tests/legacy/system/test_edb_padstacks.py
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svandenb-dev svandenb-dev merged commit 0ee121c into main Dec 19, 2024
29 checks passed
@svandenb-dev svandenb-dev deleted the reduce_via_in_box branch December 19, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grpc-transition Changes that need to be included in gRPC transition testing Anything related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants