-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Reduce via in bounding box #946
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #946 +/- ##
==========================================
+ Coverage 82.67% 82.69% +0.02%
==========================================
Files 160 160
Lines 21098 21117 +19
==========================================
+ Hits 17442 17462 +20
+ Misses 3656 3655 -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test
@boyang2022 please fix the conflicts then we can merge. |
# Conflicts: # src/pyedb/dotnet/edb_core/padstack.py # tests/legacy/system/test_edb_padstacks.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This new feature reduced the number of vias inside a bounding box