-
Notifications
You must be signed in to change notification settings - Fork 59
feat: Typing improvements #4761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Gobot1234
wants to merge
21
commits into
main
Choose a base branch
from
jhilton/typing-improvements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+143,696
−1,026
Open
Changes from 10 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
4f2c990
Add type level support for passing Path instances to download_file
Gobot1234 1ddf8e8
Add typing_extensions
Gobot1234 7825ff4
Fix inheritance for Meshing
Gobot1234 90d69a0
Fix create_launcher allowing None
Gobot1234 654deb4
Update launchers typing to be more specific
Gobot1234 ec258c3
Fix ci
Gobot1234 00c3a85
Fix ci again
Gobot1234 b6d2e3e
remove accidental commits
Gobot1234 0a48f90
run pyupgrade for moving typing to builtins and a couple of other things
Gobot1234 7b36a1c
fix some np.arrays that are meant to be ndarrays in types
Gobot1234 c04b413
pre-fix the conflict that will happen
Gobot1234 08e5525
add types for services
Gobot1234 7c2e9c3
Merge branch 'jhilton/typing-improvements' of https://github.com/ansy…
Gobot1234 0acf4ea
fix some low hanging fruit
Gobot1234 e6a7bf9
Merge remote-tracking branch 'origin/main' into jhilton/typing-improv…
Gobot1234 2ea0029
fix broken imports
Gobot1234 f28ce78
chore: adding changelog file 4761.added.md [dependabot-skip]
pyansys-ci-bot 316128d
make the other imported modules not show up in __all__
Gobot1234 79956f3
pass bool
Gobot1234 4984170
respond to some review
Gobot1234 e130f13
add project infra for typechecking
Gobot1234 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing
bytesandos.PathLike[bytes]from PathType is a breaking change that could affect existing code passing bytes paths. This should be documented in the changelog or reconsidered if bytes paths are used in the codebase.