Open
Conversation
Collaborator
prmukherj
commented
May 5, 2026
- The no-codegen ci step was removed.
- Codegen markers from pytests were removed as they don't have any significance now.
- MakeFile was cleaned up by removing unrequired markers.
- All pytest markers upto 24.2 were removed as they don't make sense now as we are testing only from 24R2
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Removes legacy pytest markers and CI/make targets related to code generation and older Fluent versions, aligning the test suite with the currently supported version range.
Changes:
- Removed
codegen_requiredmarkers across many tests and dropped the marker definition frompyproject.toml. - Removed older
fluent_version(>=...)markers (especially <= 24.2-era constraints) and deleted version-specific test targets inMakefile. - Removed the weekly “without codegen” GitHub Actions workflow.
Reviewed changes
Copilot reviewed 48 out of 48 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_type_stub.py | Removes codegen_required marker from a version-pinned stub test. |
| tests/test_tui_api.py | Removes codegen_required marker from TUI API test. |
| tests/test_solvermode/test_species_model.py | Removes older fluent_version gating marker. |
| tests/test_solvermode/test_named_expressions.py | Removes older fluent_version gating marker. |
| tests/test_solvermode/test_initialization.py | Removes older fluent_version gating marker. |
| tests/test_solvermode/test_boundaries.py | Removes codegen_required and older version gating marker. |
| tests/test_solver_monitors.py | Drops pytest import and removes older version marker. |
| tests/test_solution_variables.py | Removes older fluent_version gating markers. |
| tests/test_settings_api.py | Removes older fluent_version gating markers on multiple tests. |
| tests/test_session.py | Removes older fluent_version gating markers on multiple tests. |
| tests/test_server_meshing_workflow.py | Removes codegen_required markers; retains modern version gates (>=26.1). |
| tests/test_search.py | Removes codegen_required markers; retains version pinning markers. |
| tests/test_scheme_eval_231.py | Removes older fluent_version gating marker. |
| tests/test_rp_vars.py | Removes older fluent_version gating markers. |
| tests/test_reduction.py | Removes older fluent_version gating markers. |
| tests/test_pure_mesh_vs_mesh_workflow.py | Removes codegen_required and older version gating markers. |
| tests/test_preferences.py | Removes codegen_required markers from preference tests. |
| tests/test_pre_post_session.py | Removes older fluent_version gating marker from skipped test. |
| tests/test_physical_quantities.py | Removes older fluent_version gating marker from developer-only test. |
| tests/test_new_meshing_workflow.py | Removes codegen_required and older fluent_version gating markers; deletes a legacy version-pinned test. |
| tests/test_meshingmode/test_meshing_launch.py | Removes codegen_required from meshing launch tests. |
| tests/test_meshing_workflow.py | Removes codegen_required and older fluent_version gating markers. |
| tests/test_meshing_utilities.py | Removes codegen_required marker; keeps modern version gate. |
| tests/test_launcher_remote.py | Removes codegen_required and older fluent_version gating marker. |
| tests/test_launcher.py | Removes older fluent_version gating markers. |
| tests/test_icing_session.py | Drops pytest import and removes older version marker. |
| tests/test_fluent_version_marker.py | Removes older “>=xx.x” marker examples, leaving only “any/latest”. |
| tests/test_fluent_session.py | Removes older fluent_version gating marker. |
| tests/test_fluent_fixes.py | Removes older fluent_version gating markers. |
| tests/test_flobject.py | Removes codegen_required and older version gating markers on select tests. |
| tests/test_file_transfer_service.py | Removes codegen_required and older fluent_version gating marker from skipped test. |
| tests/test_field_data.py | Removes older fluent_version and codegen_required markers in several places. |
| tests/test_events_manager.py | Removes older fluent_version gating markers. |
| tests/test_error_handling.py | Removes older fluent_version gating marker. |
| tests/test_datamodel_service.py | Removes codegen_required and older version gating markers across many tests. |
| tests/test_data_model_cache.py | Removes codegen_required and older version gating markers. |
| tests/test_codegen.py | Removes codegen_required markers; keeps modern version gate where present. |
| tests/test_cad_to_post_wtm.py | Removes codegen_required marker from nightly test. |
| tests/test_cad_to_post_ftm.py | Removes codegen_required marker from nightly test. |
| tests/test_builtin_settings.py | Removes codegen_required and older version gating markers across several tests. |
| tests/test_batch_ops.py | Removes older fluent_version gating markers. |
| tests/test_aero_session.py | Removes older fluent_version gating markers. |
| tests/parametric/test_parametric_workflow.py | Removes older fluent_version gating marker. |
| tests/integration/test_optislang/test_optislang_integration.py | Removes codegen_required markers from nightly integration tests. |
| pyproject.toml | Removes codegen_required marker definition from pytest config. |
| doc/changelog.d/5107.maintenance.md | Adds changelog entry for the maintenance change. |
| Makefile | Removes older version targets and all *-no-codegen targets. |
| .github/workflows/test-run-wo-codegen-weekly.yml | Deletes the scheduled workflow that ran tests without codegen. |
Comments suppressed due to low confidence (1)
tests/test_search.py:1
- Several tests in this file are pinned to run only on Fluent 24.2 (
==24.2). If the intent is to run tests across supported versions starting at 24R2 (as the PR description suggests), consider switching these to a minimum bound (e.g.,>=24.2) unless there is a concrete need to restrict them to exactly 24.2.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Up to standards ✅🟢 Issues
|
mkundu1
approved these changes
May 5, 2026
hpohekar
approved these changes
May 5, 2026
seanpearsonuk
approved these changes
May 5, 2026
5cf22b9 to
9e49bcd
Compare
22e6ba2 to
57e8545
Compare
57e8545 to
084d9dc
Compare
084d9dc to
b7a1c32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.