Skip to content

feat: separate graphics target #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
clatapie wants to merge 40 commits into
base: main
Choose a base branch
from
Draft

feat: separate graphics target #567

clatapie wants to merge 40 commits into from

Conversation

@clatapie
Copy link
Contributor

@clatapie clatapie commented Apr 3, 2025

Making graphics an optional target inside PyMAPDL Reader. If users now want graphics features they can install the package as follows:

pip install ansys-mapdl-reader[graphics]

Other tasks done:

  • Restructuring CI/CD.
  • Removing requirements files in order to use .[target] as it is common practice.

@clatapie clatapie added the enhancement New feature or request label Apr 3, 2025
@clatapie clatapie requested review from a team and RobPasMue April 3, 2025 11:27
@clatapie clatapie self-assigned this Apr 3, 2025
@clatapie clatapie marked this pull request as draft April 3, 2025 12:52
RobPasMue
RobPasMue reviewed Apr 3, 2025
View reviewed changes
clatapie
clatapie commented Apr 3, 2025
View reviewed changes
pre-commit-ci bot and others added 17 commits April 3, 2025 15:02
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
4550b13 
for more information, see https://pre-commit.ci
@clatapie
fix: are_graphics_available method
9b323d0
@clatapie
Merge branch 'feat/separate-graphics' of https://github.com/pyansys/p…
2c04884 
…ymapdl-reader into feat/separate-graphics
@clatapie
fix: applying @RobPasMue's suggestions pv=None
d506e20
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
1fdb87b 
for more information, see https://pre-commit.ci
@clatapie
fix: pre-commit
33198a4
@clatapie
Merge branch 'feat/separate-graphics' of https://github.com/pyansys/p…
e2ad58f 
…ymapdl-reader into feat/separate-graphics
@clatapie
fix: doc and @wraps
6965688
@clatapie
fix: remove checkout from doc-build action
561c7df
@clatapie
fix: unit tests
5753023
@clatapie
fix: unit tests - 2
99ad42c
@clatapie
fix: unit tests - 3
d1c968e
@clatapie
fix: skip_no_graphics
e887807
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
b59f36c 
for more information, see https://pre-commit.ci
@clatapie
fix: adding latest changes - issue with vtk
62d16bc
@clatapie
Merge branch 'feat/separate-graphics' of https://github.com/pyansys/p…
c18d169 
…ymapdl-reader into feat/separate-graphics
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
009ca24 
for more information, see https://pre-commit.ci
@RobPasMue
Copy link
Member

RobPasMue commented Apr 7, 2025

Let's hold off on this one for now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@germa89 germa89 germa89 left review comments

@RobPasMue RobPasMue RobPasMue left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@clatapie clatapie

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@clatapie @RobPasMue @germa89