Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check new version from pypi instead of our api: fix pysimai version check #110

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

awoimbee
Copy link
Collaborator

🎫 https://app.shortcut.com/simai/story/26689/pysimai-fetch-latest-release-from-pypi

Our API stopped containing the latest pysimai version when it moved to this repo.
Since it's now on pypi we can just query there instead of querying our API.

I kept warn_package_outdated quite generic so internal packages can use it too (just like they did with _check_for_new_version before).

@awoimbee awoimbee requested review from yias and tmpbeing November 19, 2024 15:31
@awoimbee awoimbee self-assigned this Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 76.19048% with 5 lines in your changes missing coverage. Please review.

Project coverage is 85.48%. Comparing base (9612243) to head (128463c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/simai/core/client.py 57.14% 3 Missing ⚠️
src/ansys/simai/core/utils/misc.py 85.71% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
- Coverage   85.55%   85.48%   -0.07%     
==========================================
  Files          44       44              
  Lines        2630     2639       +9     
==========================================
+ Hits         2250     2256       +6     
- Misses        380      383       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

src/ansys/simai/core/utils/misc.py Show resolved Hide resolved
src/ansys/simai/core/client.py Show resolved Hide resolved
@awoimbee awoimbee merged commit e0b8b3c into main Nov 22, 2024
31 of 33 checks passed
@awoimbee awoimbee deleted the aw/check-new-version-from-pypi branch November 22, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants