Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add options for using custom TLS CA bundles #112

Merged
merged 8 commits into from
Nov 28, 2024
Merged

Add options for using custom TLS CA bundles #112

merged 8 commits into from
Nov 28, 2024

Conversation

awoimbee
Copy link
Collaborator

@awoimbee awoimbee commented Nov 26, 2024 •
edited
Loading

https://app.shortcut.com/simai/story/26712/tls-certs-option-to-use-system-certs-to-disable-validation

Allows users to:

  • use system CA certs (should fix issues with https://zscaler.com)
  • provide a custom CA bundle without using REQUESTS_CA_BUNDLE
  • disable verification (for troubleshooting)

@awoimbee awoimbee self-assigned this Nov 26, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation maintenance Package and maintenance related labels Nov 26, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.63%. Comparing base (bd2b409) to head (9aca5ba).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
+ Coverage   85.48%   85.63%   +0.15%     
==========================================
  Files          44       44              
  Lines        2639     2667      +28     
==========================================
+ Hits         2256     2284      +28     
  Misses        383      383

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@awoimbee awoimbee force-pushed the aw/configuration-for-custom-ca-bundle branch from 9319b93 to 8b507f3 Compare November 27, 2024 15:28
@awoimbee awoimbee marked this pull request as ready for review November 27, 2024 17:06
@awoimbee awoimbee requested review from yias and a team as code owners November 27, 2024 17:06
@awoimbee awoimbee requested review from tmpbeing and removed request for a team November 27, 2024 17:06
tmpbeing
tmpbeing approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@tmpbeing tmpbeing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

tests/test_client_config_tls_ca_bundle.py Outdated Show resolved Hide resolved
src/ansys/simai/core/api/mixin.py Show resolved Hide resolved
yias
yias approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@yias yias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine

@awoimbee awoimbee merged commit 74da848 into main Nov 28, 2024
28 of 29 checks passed
@awoimbee awoimbee deleted the aw/configuration-for-custom-ca-bundle branch November 28, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmpbeing tmpbeing tmpbeing approved these changes

@yias yias yias approved these changes

Assignees

@awoimbee awoimbee

Labels
documentation Improvements or additions to documentation maintenance Package and maintenance related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@awoimbee @yias @tmpbeing