Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check project is trainable before build #113

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

tmpbeing
Copy link
Collaborator

Also fix an issue with translating a model configuration payload into ModelConfiguration object

@tmpbeing tmpbeing requested review from yias and a team as code owners November 27, 2024 12:49
@tmpbeing tmpbeing requested review from awoimbee and removed request for a team November 27, 2024 12:49
@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New features or code improvements labels Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 79.16667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 85.60%. Comparing base (bd2b409) to head (180f159).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/simai/core/data/models.py 71.42% 2 Missing ⚠️
src/ansys/simai/core/data/projects.py 66.66% 2 Missing ⚠️
src/ansys/simai/core/data/model_configuration.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
+ Coverage   85.48%   85.60%   +0.11%     
==========================================
  Files          44       44              
  Lines        2639     2681      +42     
==========================================
+ Hits         2256     2295      +39     
- Misses        383      386       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@awoimbee awoimbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but whyy da property

src/ansys/simai/core/data/models.py Outdated Show resolved Hide resolved
src/ansys/simai/core/data/projects.py Outdated Show resolved Hide resolved
tests/test_projects.py Outdated Show resolved Hide resolved
Also fix an issue with translating a model configuration payload into ModelConfiguration object
@tmpbeing tmpbeing force-pushed the feat/check-project-is-trainable-before-build branch from bcc47f4 to 180f159 Compare December 2, 2024 11:14
@tmpbeing tmpbeing requested a review from awoimbee December 2, 2024 11:19
Copy link
Collaborator

@awoimbee awoimbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

@tmpbeing tmpbeing merged commit 9d80677 into main Dec 3, 2024
32 of 33 checks passed
@tmpbeing tmpbeing deleted the feat/check-project-is-trainable-before-build branch December 3, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants