[feat] Support post processing predict as learnt and predict on cells for surface variables #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yias
requested review from
citronella3alain and
awoimbee
and removed request for
a team
github-actions
bot
added
the
documentation
tmpbeing
reviewed
Dec 26, 2024
| @@ -56,6 +56,14 @@ Available postprocessings | |||
| :members: | |||
|
|
|||
|
|
|||
| .. autoclass:: PostProcessingOnCells() | |||
| :members: | |||
There was a problem hiding this comment.
Might want to have inherited-members as well.
| @@ -274,6 +275,40 @@ class SurfaceVTP(_PostProcessingVTKExport): | |||
| """ | |||
|
|
|||
|
|
|||
| class PostProcessingOnCells(SurfaceVTP): | |||
There was a problem hiding this comment.
I didn't follow the product story but these class name seems too generic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables users to trigger post-processing on surface variables with location options;
on cellsoras learnt.To manage the selection of endpoints for the two options, the classes
PostProcessingOnCellsandPostProcessingAsLearntare introduced as child-classes ofSurfaceVTP. These choices are enumerated inPPSurfaceLocation. The methodsPredictionPostProcessings.surface_vtpandSelectionPostProcessingsMethods.surface_vtphave now the argumentpp_location, which should be one enumeration option ofPPSurfaceLocation. The default option is set toStory: [sc-26496]
Tests
PS. It requires merging the corresponding PR of the API support.