-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overall doc review #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, thanks ! Just some very minor comments.
As for your suggestion. Some of them are already in our backlog, the others I'll bring to our product team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fantastic as always!
Incorporate feedback. Great catches all! Co-authored-by: Revathy Venugopal <[email protected]> Co-authored-by: Marc Planelles <[email protected]>
🎉 |
General edits to RST files include using first person, active voice, and present tense when possible.
@tmpbeing, @Revathyvenugopal162, @jorgepiloto The acceptance and merging of this PR completes my overall doc review.
However, some observations follow. These can be moved into one or more issues and addressed in later PRs.
classmethod clean_url(url)
configuration option or theclassmethod prompt(values)
credential option.Postprocessings
page has occurrences ofSurfaceEvol
. There is no English explanation of what this code entity is. For example, the description for thesurface_eval
method says: "Compute or get the SurfaceEvol for specific parameters." I didn't want to guess what "SurfaceEvol" was (although it is likely surface evolution). However, you should use plain English here in this docstring and in some others.