Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cicd: preparing for public release #19

Merged
merged 3 commits into from
Jan 19, 2024
Merged

cicd: preparing for public release #19

merged 3 commits into from
Jan 19, 2024

Conversation

RobPasMue
Copy link
Member

As title says

@RobPasMue RobPasMue requested a review from tmpbeing January 19, 2024 14:36
@RobPasMue RobPasMue self-assigned this Jan 19, 2024
@github-actions github-actions bot added the maintenance Package and maintenance related label Jan 19, 2024
tmpbeing
tmpbeing approved these changes Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@tmpbeing tmpbeing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you only push to the public repo ? No private repo ?

@RobPasMue
Copy link
Member Author

So you only push to the public repo ? No private repo ?

Pushing to the private PyPI is not explicitly needed. the private PyPI will look outside (i.e. public PyPI) if it can't find a package. So no need to duplicate the upload process.

@RobPasMue RobPasMue merged commit c58d59d into main Jan 19, 2024
30 checks passed
@RobPasMue RobPasMue deleted the cicd/public-release branch January 19, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmpbeing tmpbeing tmpbeing approved these changes

Assignees

@RobPasMue RobPasMue

Labels
maintenance Package and maintenance related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobPasMue @tmpbeing