build preset to take only supported values #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
==========================================
+ Coverage 82.57% 82.64% +0.06%
==========================================
Files 46 46
Lines 2543 2553 +10
==========================================
+ Hits 2100 2110 +10
Misses 443 443 ☔ View full report in Codecov by Sentry. |
awoimbee
approved these changes
Sep 13, 2024
yias
deleted the
ibatzian/feature/sc-24065/semantics-for-build-preset
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR forces the value of
build_presetin model configuration to be one of the supported values.When the user sets a non supported values in
build_preset, anInvalidArgumenterror gets raised.Story: [sc-24065]