Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add simai.training_data.list(filters=...) #86

Merged
merged 7 commits into from
Sep 25, 2024
Merged

Conversation

awoimbee
Copy link
Collaborator

[sc-24682]

This will unlock #56 (comment)

@awoimbee awoimbee self-assigned this Sep 17, 2024
@github-actions github-actions bot added the maintenance Package and maintenance related label Sep 17, 2024
@awoimbee awoimbee added the enhancement New features or code improvements label Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.64%. Comparing base (43cfc3d) to head (dd86d78).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
+ Coverage   83.39%   83.64%   +0.25%     
==========================================
  Files          46       46              
  Lines        2565     2586      +21     
==========================================
+ Hits         2139     2163      +24     
+ Misses        426      423       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@tmpbeing tmpbeing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature but it needs documentation

@awoimbee
Copy link
Collaborator Author

awoimbee commented Sep 23, 2024

Sphinx really sucks with type annotations. I had a hard time just getting it to work and I hate the end result (it's unreadable):
image

(btw I had to force push because of conflicts)

Copy link

@mmeisso mmeisso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

@awoimbee awoimbee merged commit aecfa3b into main Sep 25, 2024
33 checks passed
@awoimbee awoimbee deleted the aw/td-list-filters branch September 25, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants