Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raw_confidence_score property for predictions #87

Conversation

kliment-slice
Copy link
Contributor

[sc-19036]
Added:

  • raw_confidence_score property to predictions (rounded to 2 decimal points to match the UI)
  • Validation checks
  • Test

@kliment-slice kliment-slice added the enhancement New features or code improvements label Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.43%. Comparing base (4fdb9a3) to head (6dcd5ae).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
+ Coverage   82.67%   83.43%   +0.76%     
==========================================
  Files          46       46              
  Lines        2557     2572      +15     
==========================================
+ Hits         2114     2146      +32     
+ Misses        443      426      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@awoimbee awoimbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have questions/remarks (plz answer before merging), but it works

src/ansys/simai/core/data/predictions.py Outdated Show resolved Hide resolved
src/ansys/simai/core/data/predictions.py Outdated Show resolved Hide resolved
tests/test_predictions.py Outdated Show resolved Hide resolved
@kliment-slice kliment-slice merged commit 3e999f2 into main Sep 23, 2024
33 checks passed
@kliment-slice kliment-slice deleted the feature/sc-19036/numerical-value-of-confidence-score-accessible branch September 23, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants