Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check geometry generation function has a suitable signature (optimization) #90

Conversation

kliment-slice
Copy link
Contributor

[sc-24855]
Check geometry_generation_fn signature matches geometry_parameters

@kliment-slice kliment-slice added the enhancement New features or code improvements label Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.51%. Comparing base (aecfa3b) to head (5d43ad4).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
- Coverage   83.64%   83.51%   -0.13%     
==========================================
  Files          46       44       -2     
  Lines        2586     2572      -14     
==========================================
- Hits         2163     2148      -15     
- Misses        423      424       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@tmpbeing tmpbeing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat

Copy link
Collaborator

@awoimbee awoimbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

tests/test_optimizations.py Outdated Show resolved Hide resolved
@kliment-slice kliment-slice merged commit f9a5b04 into main Oct 2, 2024
32 of 33 checks passed
@kliment-slice kliment-slice deleted the feature/sc-24855/parametrized-optimization-sdk-should-check branch October 2, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants