Fix filters in TrainingDataDirectory.list
#99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #99 +/- ##
=======================================
Coverage 83.51% 83.52%
=======================================
Files 44 44
Lines 2572 2573 +1
=======================================
+ Hits 2148 2149 +1
Misses 424 424 ☔ View full report in Codecov by Sentry. |
mmeisso
requested changes
Oct 10, 2024
mmeisso
approved these changes
Oct 10, 2024
yias
deleted the
ibatzian/bug/sc-25499/sdk-trainingdatadirectory-list-with-filters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When setting a filter in
TrainingDataDirectory.list, the dictionaries into_raw_filtersare not encoded to a json object correctly. This causes the server to crash and the request to return a 500 server error.This PR fixes this issue with calling
json.dumpsto properly encode the disctionaries.story: [sc-25499]
Test