-
Notifications
You must be signed in to change notification settings - Fork 2.5k
feat(Divider DotLoading): unified provision of custom prefixCls #6981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature
Are you sure you want to change the base?
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @EmilyyyLiu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant enhancement to the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
本次 PR 旨在为 Divider 组件统一提供自定义 prefixCls 的功能。代码实现上,通过 useConfig 和 getPrefixCls 来获取类名前缀,替代了原有的硬编码值,这方向是正确的。
然而,我发现了一个关键问题:相关的 .less 文件中的样式选择器仍然是硬编码的,这会导致在使用自定义前缀时样式失效。此外,有一个关于导入顺序的小建议,以提高代码的可读性。
请查看具体的审查意见。
| export const Divider: FC<DividerProps> = p => { | ||
| const props = mergeProps(defaultProps, p) | ||
| const { getPrefixCls } = useConfig() | ||
| const prefixCls = getPrefixCls('divider', props.prefixCls) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature #6981 +/- ##
===========================================
+ Coverage 92.95% 92.97% +0.01%
===========================================
Files 337 337
Lines 7368 7372 +4
Branches 1871 1835 -36
===========================================
+ Hits 6849 6854 +5
- Misses 483 510 +27
+ Partials 36 8 -28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

统一添加自定义class 前缀
关联issue #6960