Skip to content

Conversation

@EmilyyyLiu
Copy link
Contributor

统一添加自定义class 前缀
关联issue #6960

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Oct 28, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2025

Preview is ready

@coderabbitai
Copy link

coderabbitai bot commented Oct 28, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist
Copy link

Summary of Changes

Hello @EmilyyyLiu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant enhancement to the Divider component by enabling a unified and customizable approach to its CSS class prefix. By integrating with the ConfigProvider and allowing a prefixCls property, the change provides greater flexibility for developers to align the component's styling with their specific design requirements, addressing a previously identified issue related to class prefix customization.

Highlights

  • Customizable Class Prefix: The Divider component now supports a custom prefixCls property, allowing developers to override the default CSS class prefix for better styling control and integration with different design systems.
  • Integration with ConfigProvider: The component has been updated to utilize the useConfig hook, enabling it to dynamically retrieve the class prefix from a global ConfigProvider, ensuring a unified approach to class prefix management across components.
  • Removal of Hardcoded Prefix: The hardcoded adm-divider class prefix has been removed, making the component more flexible and configurable.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 28, 2025

npm i https://pkg.pr.new/ant-design/ant-design-mobile/antd-mobile@6981

commit: 40bcf4c

@dosubot dosubot bot added the feature label Oct 28, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

本次 PR 旨在为 Divider 组件统一提供自定义 prefixCls 的功能。代码实现上,通过 useConfiggetPrefixCls 来获取类名前缀,替代了原有的硬编码值,这方向是正确的。

然而,我发现了一个关键问题:相关的 .less 文件中的样式选择器仍然是硬编码的,这会导致在使用自定义前缀时样式失效。此外,有一个关于导入顺序的小建议,以提高代码的可读性。

请查看具体的审查意见。

export const Divider: FC<DividerProps> = p => {
const props = mergeProps(defaultProps, p)
const { getPrefixCls } = useConfig()
const prefixCls = getPrefixCls('divider', props.prefixCls)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

此更改引入了可自定义的 prefixCls,但 src/components/divider/divider.less 中的 CSS 样式仍然硬编码使用了 adm-divider 前缀(例如在第 6 行的 .adm-divider-horizontal 和第 36 行的 .adm-divider-vertical)。当使用自定义前缀时,这将导致组件样式失效。为了让此功能正常工作,需要更新 .less 文件以使用变量来构造所有相关的 CSS 选择器,例如使用 .@{class-prefix-divider}-horizontal 而不是 .adm-divider-horizontal

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.97%. Comparing base (bfde19d) to head (40bcf4c).

Additional details and impacted files
@@             Coverage Diff             @@
##           feature    #6981      +/-   ##
===========================================
+ Coverage    92.95%   92.97%   +0.01%     
===========================================
  Files          337      337              
  Lines         7368     7372       +4     
  Branches      1871     1835      -36     
===========================================
+ Hits          6849     6854       +5     
- Misses         483      510      +27     
+ Partials        36        8      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Oct 28, 2025
@EmilyyyLiu EmilyyyLiu changed the title feat(Divider): unified provision of custom prefixCls feat(Divider DotLoading): unified provision of custom prefixCls Oct 28, 2025
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Oct 28, 2025
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant