Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typography double tooltip when hover operations #49008

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

zhouzhongyuan
Copy link

@zhouzhongyuan zhouzhongyuan commented May 21, 2024

中文版模板 / Chinese template

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

  1. Typography.Text with ellipsis and copyable trigger both tooltips instead of one #48733

💡 Background and solution

Background

Typography.Text with ellipsis and copyable trigger both tooltips instead of one, just like below:
image

Solution

Modify the structure of Typography component. When hovering operation like copy or edit, it only trigger it's own tooltip instead of trigger the text's tooltip.

📝 Changelog

Language Changelog
🇺🇸 English fix: typograph double tooltip when hover operations
🇨🇳 Chinese 修复Typography排版组件在hover 复制、编辑等操作是弹出两个tooltip的bug

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented May 21, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented May 21, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented May 21, 2024

👁 Visual Regression Report for PR #49008 Failed ❌

🎯 Target branch: master (c0839ca)
📖 View Full Report ↗︎

Expected (Branch master) Actual (Current PR) Diff
calendar-customize-header.compact.png calendar-customize-header.compact.png calendar-customize-header.compact.png calendar-customize-header.compact.png
calendar-customize-header.compact.png calendar-customize-header.compact.png calendar-customize-header.compact.css-var.png calendar-customize-header.compact.css-var.png
calendar-customize-header.dark.png calendar-customize-header.dark.png calendar-customize-header.dark.png calendar-customize-header.dark.png
calendar-customize-header.dark.png calendar-customize-header.dark.png calendar-customize-header.dark.css-var.png calendar-customize-header.dark.css-var.png
calendar-customize-header.default.png calendar-customize-header.default.png calendar-customize-header.default.png calendar-customize-header.default.png
calendar-customize-header.default.png calendar-customize-header.default.png calendar-customize-header.default.css-var.png calendar-customize-header.default.css-var.png
config-provider-warning.compact.png config-provider-warning.compact.png config-provider-warning.compact.png config-provider-warning.compact.png
config-provider-warning.compact.png config-provider-warning.compact.png config-provider-warning.compact.css-var.png config-provider-warning.compact.css-var.png
config-provider-warning.dark.png config-provider-warning.dark.png config-provider-warning.dark.png config-provider-warning.dark.png
config-provider-warning.dark.png config-provider-warning.dark.png config-provider-warning.dark.css-var.png config-provider-warning.dark.css-var.png

Check Full Report for details


If you think the visual diff is acceptable, please check:

  • Visual diff is acceptable

Copy link

codesandbox-ci bot commented May 21, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (828360c) to head (0e9b3df).

Current head 0e9b3df differs from pull request most recent head cffeb04

Please upload reports for the commit cffeb04 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #49008   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          750       749    -1     
  Lines        13129     13066   -63     
  Branches      3442      3431   -11     
=========================================
- Hits         13129     13066   -63     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhouzhongyuan
Copy link
Author

zhouzhongyuan commented May 23, 2024

Hi, @li-jia-nan, The action run says: This workflow is awaiting approval from a maintainer.

Could you please help me to approval it?

The runs link is here (updated)

@zhouzhongyuan zhouzhongyuan changed the title fix: typograph double tooltip when hover operations fix: typography double tooltip when hover operations Jun 4, 2024
@zhouzhongyuan zhouzhongyuan reopened this Jun 4, 2024
@zhouzhongyuan
Copy link
Author

Hi,@zombieJ , I am sorry to trouble you. Could you please help me to approve the workflow?
The link is: https://github.com/ant-design/ant-design/actions/runs/9363941966

@zhouzhongyuan zhouzhongyuan reopened this Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant